Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AggregateFactory to the example code #64

Merged
merged 2 commits into from Oct 20, 2014
Merged

Add AggregateFactory to the example code #64

merged 2 commits into from Oct 20, 2014

Conversation

mbadolato
Copy link
Contributor

PR #42 changes were not applied to the examples directory, causing breakage of unit tests in /examples

PR #42 changes were not applied to the examples directory, causing breakage of unit tests in /examples
@@ -105,7 +107,7 @@ class InvitationRepository extends Broadway\EventSourcing\EventSourcingRepositor
{
public function __construct(Broadway\EventStore\EventStoreInterface $eventStore, Broadway\EventHandling\EventBusInterface $eventBus)
{
parent::__construct($eventStore, $eventBus, 'Invitation');
parent::__construct($eventStore, $eventBus, 'Invitation', new PublicConstructorAggregateFactory());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the examples we use the complete namespace. It is easier to spot where a specific class is when quickly browsing through the examples.

@mbadolato
Copy link
Contributor Author

@wjzijderveld Fixed

@wjzijderveld
Copy link
Member

👍

fritsjanb added a commit that referenced this pull request Oct 20, 2014
…xample_code

Add AggregateFactory to the example code
@fritsjanb fritsjanb merged commit 633b6f6 into broadway:master Oct 20, 2014
@fritsjanb
Copy link
Contributor

👍

Thanks @mbadolato

@mbadolato mbadolato deleted the add_aggregate_root_factory_to_example_code branch October 23, 2014 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants