Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sort button #894

Merged
merged 13 commits into from
Feb 19, 2023
Merged

Add sort button #894

merged 13 commits into from
Feb 19, 2023

Conversation

qarmin
Copy link
Owner

@qarmin qarmin commented Jan 7, 2023

Fixes #866
Fixes #898 - also changes strange Try at: error message
Part of #909

Currently is added ascending sorting for:

  • file names/folder names
  • parent folder names
  • size
  • selection

For reverse sorting I need to think how this will look in GUI(maybe same buttons but with rev/desc in name?)

Fixes also problem with invalid tags values when using same music feature with references folders

Sorting will be only available when groups of results are visible, because in simple view, everything works out of box with gnome

This PR is much bigger than I assumed, because I'm too lazy to do MR for every patch and then rebase it(but I'm going to improve)

@qarmin qarmin added the enhancement New feature or request label Jan 7, 2023
@qarmin qarmin marked this pull request as draft January 7, 2023 08:35
@qarmin qarmin marked this pull request as ready for review February 19, 2023 09:12
@qarmin qarmin merged commit f1c6e6d into master Feb 19, 2023
@qarmin qarmin deleted the sorting branch February 19, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checking for broken files fails with PDF Documents Sorting by clicking on column name don't work
1 participant