Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Improve hashing strength on compatible systems #7

Open
phxql opened this issue Jan 22, 2018 · 0 comments
Open

Suggestion: Improve hashing strength on compatible systems #7

phxql opened this issue Jan 22, 2018 · 0 comments
Assignees

Comments

@phxql
Copy link
Contributor

phxql commented Jan 22, 2018

A PR which implements hashing with PBKDF2 SHA-256 had do be declined because Android doesn't support that algorithm.

Maybe we should implement a platform specific list of hash algorithms in a config to always select the strongest available. That way, a real Java application would get HMAC-SHA256 while Android stays on HMAC-SHA1.

Downsides: That way, a hash encoded with Heimdall on Windows can't be used anymore on Android, even if they hadve been created with the same Heimdall version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant