Updated PBKDF2 algorithm to 'PBKDF2WithHmacSHA256' #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adopted change in unit tests and added additional test to ensure that required rehashing is detected correctly.
…added base class for all PBKDF2 implementations
… handling on windows
|
PBKDF2 with SHA-256 is unfortunately not supported on Android. I took some changes (update of dependency versions, the dependency plugin and the SecureHash code for windows) and merged them in the master. I also created the issue #7 to think about multiple sets of hash algorithms per platform. Thanks for the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adopted change in unit tests and added an additional test to ensure that the required rehashing is detected correctly.
Marked
PasswordImplas package local as it should be instantiated by thePasswordFactoryand there's no reason to make itpublic.Set JDK version to 1.8 to be able to use 'PBKDF2WithHmacSHA256'.
'PBKDF2WithHmacSHA1' might not be the best solution anymore due to known security vulnerabilities in SHA1.
Updated
SecureSaltProviderto use specific PRNG on Windows.Introduced base class for PBKDF2 implementations to avoid code duplications.