fix: page context

qawolf · Aug 17, 2020 · 208089c · 208089c
1 parent ef797cc
commit 208089c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 6 deletions.
diff --git a/src/build-code/buildStepLines.ts b/src/build-code/buildStepLines.ts
@@ -33,7 +33,10 @@ export const buildValue = ({ action, value }: Step): string => {
   return JSON.stringify(value);
 };
 
-export const buildExpressionLine = (step: Step, frameVariable?: string): string => {
+export const buildExpressionLine = (
+  step: Step,
+  frameVariable?: string,
+): string => {
   const { action, event } = step;
 
   const args: string[] = [escapeSelector(event.selector)];
@@ -57,7 +60,7 @@ export const buildStepLines = (
   buildContext: StepLineBuildContext = {
     initializedFrames: new Map<string, string>(),
     initializedPages: new Set(),
-  }
+  },
 ): string[] => {
   const lines: string[] = [];
 
@@ -66,16 +69,24 @@ export const buildStepLines = (
 
   const pageVariableName = getStepPageVariableName(step);
   if (page > 0 && !initializedPages.has(page)) {
-    lines.push(`const ${pageVariableName} = await qawolf.waitForPage(context, ${page});`);
+    lines.push(
+      `const ${pageVariableName} = await qawolf.waitForPage(page.context(), ${page});`,
+    );
     initializedPages.add(page);
   }
 
   let frameVariableName: string;
   if (frameSelector) {
     frameVariableName = initializedFrames.get(frameSelector);
     if (!frameVariableName) {
-      frameVariableName = `frame${initializedFrames.size ? initializedFrames.size + 1 : ''}`;
-      lines.push(`const ${frameVariableName} = await (await ${pageVariableName}.$(${escapeSelector(frameSelector)})).contentFrame();`);
+      frameVariableName = `frame${
+        initializedFrames.size ? initializedFrames.size + 1 : ''
+      }`;
+      lines.push(
+        `const ${frameVariableName} = await (await ${pageVariableName}.$(${escapeSelector(
+          frameSelector,
+        )})).contentFrame();`,
+      );
       initializedFrames.set(frameSelector, frameVariableName);
     }
   }

diff --git a/test/build-code/buildStepLines.test.ts b/test/build-code/buildStepLines.test.ts
@@ -37,7 +37,7 @@ describe('buildStepLines', () => {
 
     expect(lines).toMatchInlineSnapshot(`
       Array [
-        "const page2 = await qawolf.waitForPage(context, 1);",
+        "const page2 = await qawolf.waitForPage(page.context(), 1);",
         "await page2.click('[data-qa=\\"test-input\\"]');",
       ]
     `);