remove type casting to work with playwright-core

qawolf · Aug 11, 2020 · 6f5e5fd · 6f5e5fd
1 parent ef4bb48
commit 6f5e5fd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/utils/context/register.ts b/src/utils/context/register.ts
@@ -49,10 +49,7 @@ export const getArtifactPath = (): string | null => {
   return artifactPath;
 };
 
-// playwright-core types are out of date
-export const register = async (
-  context: BrowserContext | any,
-): Promise<void> => {
+export const register = async (context: BrowserContext): Promise<void> => {
   Registry.instance().setContext(context);
 
   if (isRegistered(context)) return;

diff --git a/test/browser.ts b/test/browser.ts
@@ -11,8 +11,8 @@ export const connect = async (): Promise<ChromiumBrowser> => {
   if (!wsEndpoint) {
     throw new Error('Must provide QAW_WS_ENDPOINT env variable');
   }
-  // cast as ChromiumBrowser from playwright-core to make the types work
-  const browser = (await chromium.connect({ wsEndpoint })) as ChromiumBrowser;
+
+  const browser = await chromium.connect({ wsEndpoint });
   Registry.instance().setBrowser(browser);
 
   debug('connected to browser');