Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Name selectors #501

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Name selectors #501

merged 2 commits into from
Mar 10, 2020

Conversation

jperl
Copy link
Member

@jperl jperl commented Mar 9, 2020 •
edited

Resolves #499

To Do

  • adapt buildDescription for selector naming
  • serialize selectors with their names
  • update selector dictionary
  • inline step event and remove redundant keys
  • fix tests
  • add missing tests

@jperl jperl force-pushed the named-selectors branch 3 times, most recently from 41f146e to 4e4a445 Compare March 10, 2020 16:38
@jperl jperl requested a review from flaurida March 10, 2020 16:43
@jperl jperl marked this pull request as ready for review March 10, 2020 16:43
@jperl jperl merged commit b0327d9 into master Mar 10, 2020
@jperl jperl deleted the named-selectors branch March 10, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaurida flaurida flaurida approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@jperl @flaurida