Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed semicolon in PATCH_HANDLE #612

Closed
wants to merge 1 commit into from
Closed

Conversation

Cloudo
Copy link

@Cloudo Cloudo commented May 20, 2020

it prevents me from editing tests when I have "semi": false in my prettier config with error
Could not find await qawolf.create(); in caller

it prevents me from editing tests when I have `"semi": false` in my prettier config with error
`Could not find await qawolf.create(); in caller`
@flaurida
Copy link
Contributor

Hi @Cloudo thanks for the PR!

The issue with just removing the semicolon is that it will now not be included for anyone. Our code templates use semicolons so it may be a bit odd. Let us think about it a bit more, or I am happy to go into more details on what would need to happen.

@jperl
Copy link
Member

jperl commented Jun 12, 2020

I think we should replace await qawolf.create() with a comment. What do you think @flaurida?

@jperl
Copy link
Member

jperl commented Jun 16, 2020

Hi @Cloudo I believe we fixed this issue in #684.

Now we replace qawolf.create() with a comment // 🐺 create code here so this should not interfere with your code formatting anymore. I will let you know when the next release is.

@jperl jperl closed this Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants