You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement SHA-512 algorithm to protectSheet and add ValidateSheetProtect
Description
add genISOPasswordHash, which implements SHA-512 algorithm salt hash generation that supports workbookProtection and worksheetProtection.
Motivation and Context
Excel 2007 supports hash password. Since Excel 2013, SHA-512 algorithm are the default method in creating workbook protection and worksheet protection. Although worksheet protection.password works well with genSheetPasswd (Excel 2013, 2019 both support), workbook protection only support SHA-512. And next I will implement protectWorkbook.
How Has This Been Tested
I had set password to workbook protection and worksheet protection on file test/Worksheet-Workbook-Protection.xlsx with Mac Excel 2019.
unzip it and read both protection xml lines to create func TestGenISOPasswordHash test1 and test2.
test3 just run the algorithm twice to test whether hash value match.
Types of changes
Docs change / refactoring / dependency upgrade
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Merging #1115 (b2f0e49) into master (e37e060) will decrease coverage by 0.11%.
The diff coverage is 73.91%.
❗ Current head b2f0e49 differs from pull request most recent head 51cd742. Consider uploading reports for the commit 51cd742 to get more accurate results
Jonham
changed the title
feat: implement SHA-512 algorithm to ProtectSheet, add ValidateSheetProtect
feat: implement SHA-512 algorithm to ProtectSheet
Jan 6, 2022
- Make ProtectSheet support specify multi kind of hash algorithm
- Make UnprotectSheet support remove sheet protection with password verification.
- Following exported error constants or enumeration has been changed for typo fix:
* `ErrDataValidationFormulaLenth` to `ErrDataValidationFormulaLength`
* `ErrUnsupportEncryptMechanism` to `ErrUnsupportedEncryptMechanism`
* `DataValidationTypeTextLeng` to `DataValidationTypeTextLength`
size/LDenotes a PR that changes 100-499 lines, ignoring generated files.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xuri
added
the
size/L
Jonham
changed the title
implement SHA-512 algorithm to protectSheet and add ValidateSheetProtect
Description
add genISOPasswordHash, which implements SHA-512 algorithm salt hash generation that supports workbookProtection and worksheetProtection.
Motivation and Context
Excel 2007 supports hash password. Since Excel 2013, SHA-512 algorithm are the default method in creating workbook protection and worksheet protection. Although worksheet protection.password works well with
genSheetPasswd(Excel 2013, 2019 both support), workbook protection only support SHA-512. And next I will implement protectWorkbook.How Has This Been Tested
I had set password to workbook protection and worksheet protection on file
test/Worksheet-Workbook-Protection.xlsxwith Mac Excel 2019.unzip it and read both protection xml lines to create
func TestGenISOPasswordHashtest1 and test2.test3 just run the algorithm twice to test whether hash value match.
Types of changes
Checklist