Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interpreter clone() should check if receiver implements Cloneable #744

Closed
DanHeidinga opened this issue Oct 25, 2021 · 1 comment · Fixed by #943
Closed

Interpreter clone() should check if receiver implements Cloneable #744

DanHeidinga opened this issue Oct 25, 2021 · 1 comment · Fixed by #943
Assignees
@dgrove-oss

Comments

@DanHeidinga
Copy link
Collaborator

This is good for bootstrapping but we'll need to eventually check that the cloned object implements Cloneable and otherwise throw the CloneNotSupportedException

Originally posted by @DanHeidinga in #741 (comment)
@DanHeidinga DanHeidinga mentioned this issue Oct 25, 2021
Merged
@dmlloyd
Copy link
Collaborator

dmlloyd commented Oct 25, 2021

It would make sense to resolve this at the same time as #674.

@dgrove-oss dgrove-oss self-assigned this Nov 30, 2021
@dgrove-oss dgrove-oss mentioned this issue Dec 20, 2021
Merged
dgrove-oss added a commit to dgrove-oss/qbicc that referenced this issue Dec 20, 2021
@dgrove-oss
remove Clone node and use class lib implementation
8a2ed21 
Fixes qbicc#744.
Fixes qbicc#674.
dgrove-oss added a commit to dgrove-oss/qbicc that referenced this issue Dec 20, 2021
@dgrove-oss
remove Clone node and use class lib implementation
aba537c 
Fixes qbicc#744.
Fixes qbicc#674.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgrove-oss dgrove-oss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove Clone node and use class lib implementation dgrove-oss/qbicc
3 participants
@dmlloyd @dgrove-oss @DanHeidinga