remove Clone node and use class lib implementation #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgrove-oss
added
the
needs classlib support ⏳
|
Needs various fixes to Array, Class, and Object to get into a classlib release before we can merge this. Unfortunately, one of our CI test requires a partially-working clone to pass, so we can't break the existing clone support... |
dgrove-oss
force-pushed
the
clone-redux
branch
from
ff5f901
to
fe77e6c
Compare
dgrove-oss
force-pushed
the
clone-redux
branch
from
fe77e6c
to
8a2ed21
Compare
dmlloyd
approved these changes
Dec 20, 2021
dgrove-oss
force-pushed
the
clone-redux
branch
from
8a2ed21
to
aba537c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #744.
Fixes #674.