Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DI for Maven Resolver #974

Closed
dmlloyd opened this issue Dec 23, 2021 · 0 comments · Fixed by #1639
Closed

Use DI for Maven Resolver #974

dmlloyd opened this issue Dec 23, 2021 · 0 comments · Fixed by #1639
Labels
kind: task 📋 A task to fulfill an implementation requirement

Comments

@dmlloyd
Copy link
Collaborator

dmlloyd commented Dec 23, 2021

Maven Resolver makes incompatible changes in minor or micro releases, because they assume that users of that library will be using a dependency injection (DI) library in order to wire it up, instead of the legacy & deprecated ServiceLocator class that we rely on.

Add Guice or something similar to the class path and use it to acquire the initial RepositorySystem in QbiccMavenResolver via @Inject, instead of using QbiccServiceLocator which has to be fixed almost every time maven-resolver is updated.
@dmlloyd dmlloyd added the kind: task 📋 A task to fulfill an implementation requirement label Dec 23, 2021
evacchi added a commit to evacchi/qbicc that referenced this issue Jan 12, 2022
@evacchi
Use Guice for Maven Resolver
39fd5dd 
fixes qbicc#974
evacchi added a commit to evacchi/qbicc that referenced this issue Jan 12, 2022
@evacchi
Use Guice for Maven Resolver
c4beb77 
fixes qbicc#974
@evacchi evacchi mentioned this issue Jan 12, 2022
Closed
evacchi added a commit to evacchi/qbicc that referenced this issue Feb 9, 2022
@evacchi
Use Guice for Maven Resolver
db2ff00 
fixes qbicc#974
@dmlloyd dmlloyd linked a pull request Dec 15, 2022 that will close this issue
Use a custom SISU emulator instead of manually wiring services #1639
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: task 📋 A task to fulfill an implementation requirement
Projects
None yet
Milestone
No milestone
1 participant
@dmlloyd