Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When PC freeze, qBittorrent lose config #1272

Closed
TheMadSword opened this issue Jan 13, 2014 · 6 comments
Closed

When PC freeze, qBittorrent lose config #1272

TheMadSword opened this issue Jan 13, 2014 · 6 comments
Milestone

Comments

@TheMadSword
Copy link

Hi there,

My computer has currently a non-qBittorrent bug where it sometime freeze (or half-freeze). When such a thing happen, I have to reboot my computer. (It's mechanical, I have it since a while; I think the processor has a messed up register or something; like I can keep moving my mouse but everything else is frozen; and that's not always; and ctrl+alt+delete works rarely; I sometime get my video card drivers to reboot; strange stuff well).

When I relaunch qBittorrent after the freeze+hard reboot, I get the usual message when you first boot qBittorrent (like : "you're responsible for what you do" or something like that). Then I get my full torrent list, but I lose all the columns and columns' length (i.e."Added on" column isn't there by default, I have to ALWAYS re-add it). I also loose all my limit config (i.e. limit DL at 400 ko/s and upload at 50 ko/s, limit 50 max connection, stuff like that).

I'm using 3.1.4 on Windows 7 x64.

I wish the configs would be safe in case I crash (read: hard-reboot) :/. If they would load the same way torrents are loaded I think it would work (thought I didn't look at the code).

Thanks,
TheMadSword

@sledgehammer999
Copy link
Member

I have a similar problem. Windows crashes due to driver crash and qbt ALWAYS ends up losing its configuration.

This is top priority for me. I am going to make a big overhaul on how settings are managed/saved/loaded from disk. Currently, if I understand correctly the code, it continually opens and reads the settings file and maybe writes to it. This increases the chances of the file being borked during a hard reset.

However this will be marked for v3.1.6 or later. Currently the settings code is all over the place. Overhauling it takes long time. Also for these ~2 weeks I am pretty busy in real life, so I have stopped hacking on qbt. Only patches from others might get approved during this period.

@kurtisnotcurtis
Copy link

I keep getting burned by this bug, especially when I set my computer to turn off at a specified time while having qbittorrent open. Could you do something simpler than rewriting all settings, such as adding a method on successful shutdown that saves a second copy of the settings file as a backup and an init method that checks for a possible backup? I'm no expert by any means, but I love qbittorrent and would love to help if at all possible. Thanks for providing this program, it's fantastic.

@TheMadSword
Copy link
Author

Thank you sledgehammer999.

@TheMadSword
Copy link
Author

"- BUGFIX: Third attempt at fixing saving settings on OS shutdown. (sledgehammer999)"

Seems to be in 3.1.5 rather than in 3.1.6 ?

@sledgehammer999
Copy link
Member

That's another type of fixing that was made before you open this issue. The major code overhual I was talking earlier isn't done yet.

@glassez
Copy link
Member

glassez commented Feb 8, 2014

@sledgehammer999 I have a similar problem.
I believe that the problem may lie in the use of INI-format settings.
Now I'm testing my build with using of native-format settings. If you're interested, I can make an appropriate pull-request. You could make a test build and publish it to anyone else tested it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants