Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System tray icon flashes constantly on KDE Plasma (qB v.4.5.0 qt5) #18217

Closed
mozo78 opened this issue Dec 13, 2022 · 19 comments
Closed

System tray icon flashes constantly on KDE Plasma (qB v.4.5.0 qt5) #18217

mozo78 opened this issue Dec 13, 2022 · 19 comments
Labels
GUI GUI-related issues/changes OS: Linux Issues specific to Linux distributions

Comments

@mozo78
Copy link

mozo78 commented Dec 13, 2022

qBittorrent & operating system versions

qBittorrent: 4.5.0 x64
Operating system: Arch Linux x64
Qt: 5.15.7
libtorrent-rasterbar: 1:2.0.8-2

What is the problem?

System tray icon flashes constantly on KDE Plasma and never stops. See the video:
https://youtu.be/dIxJQrqPykU

Steps to reproduce

  1. Start qBittorrent to system tray.

Additional context

No response

Log(s) & preferences file(s)

No response

@mozo78 mozo78 changed the title System tray icon flashes constantly on KDE Plasma (Qb v.4.5.0 qt5) System tray icon flashes constantly on KDE Plasma (qB v.4.5.0 qt5) Dec 13, 2022
@thalieht thalieht added OS: Linux Issues specific to Linux distributions GUI GUI-related issues/changes labels Dec 13, 2022
@mozo78
Copy link
Author

mozo78 commented Dec 13, 2022

I just realized it - it flashes every time when there is a change of down or upload speed. If I download with 31MB/s and the speed changes to 30 - it flashes. If I upload with 21MB/s and it changes to whatever different value - it flashes. As we all know the speed will vary constantly, so the icon will flash constantly as well. Changing to Qt6 build doesn't change this behaviour. Using a monochrome tray icon doesn't help either.

@glassez
Copy link
Member

glassez commented Dec 14, 2022

I think it is caused by updating of tray icon tool tip:

const auto toolTip = u"%1\n%2"_qs.arg(
tr("DL speed: %1", "e.g: Download speed: 10 KiB/s").arg(Utils::Misc::friendlyUnit(status.payloadDownloadRate, true))
, tr("UP speed: %1", "e.g: Upload speed: 10 KiB/s").arg(Utils::Misc::friendlyUnit(status.payloadUploadRate, true)));
app()->desktopIntegration()->setToolTip(toolTip); // tray icon

@qbittorrent/bug-handlers
Do we really need it? Or maybe make it optional?

@mozo78
Copy link
Author

mozo78 commented Dec 14, 2022

Thank you for your help! It's very frustrating and I have to watch it during the whole day and every time I think something other happens. It irritates the side vision for sure.

@xavier2k6
Copy link
Member

Do we really need it?

Personally, I don't care or use it for any real significance.

maybe make it optional?

May be the best option....whether it's off by default etc will let other decide...have no strong preference.

@glassez
Copy link
Member

glassez commented Dec 14, 2022

maybe make it optional?

May be the best option....

In fact, the answer "yes" to any such question is the least desirable, since it involves more work, so it is always easier to either have something or not at all.
But if we delete it unconditionally, then as always there will be a few dissatisfied who will argue that "this was the most important feature for everyone, except for complete idiots, which are the qBittorrent developers".

@mozo78
Copy link
Author

mozo78 commented Dec 14, 2022

Since there's such code change, do you have this flashing guys?

@thalieht
Copy link
Contributor

thalieht commented Dec 14, 2022

I can't reproduce this, also in arch but i haven't updated the system for a month or so. Tested qBt with Qt 5.15.7 and 6.4.0.

I think it is caused by updating of tray icon tool tip:

Do we really need it?

I'm guessing people who close/minimize to tray find it useful.

@mozo78
Copy link
Author

mozo78 commented Dec 14, 2022

May be it's only on Plasma?

@thalieht
Copy link
Contributor

May be it's only on Plasma?

AH sorry i didn't mention it. I'm also on plasma.

@glassez
Copy link
Member

glassez commented Dec 14, 2022

Since there's such code change, do you have this flashing guys?

qBittorrent has such a code (that updates speed in tool tip) for years...

@mozo78
Copy link
Author

mozo78 commented Dec 14, 2022

So there's another reason for this bug...

@mozo78
Copy link
Author

mozo78 commented Dec 14, 2022

Guys, to see the icon flashing you have to download or upload something and the speed have to vary. It flashes at every speed change.

@thalieht
Copy link
Contributor

Guys, to see the icon flashing you have to download or upload something and the speed have to vary. It flashes at every speed change.

Yes it was mentioned in #18217 (comment). I doubt it matters but i can't reach such high speeds (30 MB/s).

also in arch but i haven't updated the system for a month or so

I just updated, still can't reproduce.

@mozo78
Copy link
Author

mozo78 commented Dec 14, 2022

I doubt it matters but i can't reach such high speeds (30 MB/s).

It's a random digit for the example. My max speed is 32 MB/s but it doesn't matter. I can upload some task with 15Kb/s and it'll flash.

@mozo78
Copy link
Author

mozo78 commented Dec 14, 2022

Here's a better video of the problem:
https://youtu.be/y8L_3YNNqoo

@sledgehammer999
Copy link
Member

Did it happen with v4.4.5 too?
This seems like a shortcoming/bug of Plasma.

@mozo78
Copy link
Author

mozo78 commented Dec 14, 2022

I'll check later and I'll let you know. Thank you for your answer.

@sledgehammer999
Copy link
Member

In case you can't find the 4.4.5 package for your distro, you could use the AppImage from here.

@mozo78
Copy link
Author

mozo78 commented Dec 14, 2022

Thank you - with the Appimage there's no sys tray icon at all. On Arch it's very easy to downgrade a package so I downgraded it and there's still flashing and I'm sure it didn't flashed with this version at all. It seems it's a KDE Plasma bug. Thank you all for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI GUI-related issues/changes OS: Linux Issues specific to Linux distributions
Projects
None yet
Development

No branches or pull requests

5 participants