Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot see I2P peers #18926

Closed
absolutep opened this issue May 4, 2023 · 8 comments
Closed

Cannot see I2P peers #18926

absolutep opened this issue May 4, 2023 · 8 comments

Comments

@absolutep
Copy link

qBittorrent & operating system versions

version

What is the problem?

No peers can be seen in qBittorrrent for I2P torrents.

w1

Other I2P supported torrent clients can see qBittorrent peers. As shown in screenshots.

w

Steps to reproduce

No response

Additional context

No response

Log(s) & preferences file(s)

No response

@absolutep absolutep changed the title Cannot see peers Cannot see I2P peers May 4, 2023
@xavier2k6
Copy link
Member

xavier2k6 commented May 4, 2023

@absolutep As I mentioned in #18922 (comment) @glassez has created a PR #18845 to resolve this issue but it hasn't been merged yet.

The reason is mentioned/indicated in #18921 (comment)

Basically, if that PR was merged - it would break our CI Environment as the release libtorrent versions being used do not contain the recent I2P updates.

Again, a custom build would need to be provided to you inclusive of PR #18845 or you'll have to wait for official libtorrent releases 2.0.9/1.2.19 to be used in our CI environments.

EDIT:
The builds I provided to you in #18921 (comment) DID NOT include PR #18845.

@xavier2k6
Copy link
Member

@absolutep I've created another custom build with PR #18845 for you below:
https://github.com/xavier2k6/qBittorrent/actions/runs/4883976184

Please note that only 1 build is available/successful (2.0.x), the libtorrent (1.2.x) build failed.....I can't invest much more time in investigating it.

@glassez You may be interested in the failure....

@glassez
Copy link
Member

glassez commented May 4, 2023

the libtorrent (1.2.x) build failed.....I can't invest much more time in investigating it.

@glassez You may be interested in the failure....

Latest I2P related changes were not backported to 1.2.x branch. And I'm not sure they will. So we will have to conditionally exclude support for I2P in case when qBittorrent is built with libtorrent-1.2.

@absolutep
Copy link
Author

@absolutep I've created another custom build with PR #18845 for you below: https://github.com/xavier2k6/qBittorrent/actions/runs/4883976184

Please note that only 1 build is available/successful (2.0.x), the libtorrent (1.2.x) build failed.....I can't invest much more time in investigating it.

Thank you very much @xavier2k6
Your build works perfectly and solves the issue.

w

@absolutep
Copy link
Author

If possible @glassez please consider pushing this build for general public release.
Thank you.

@xavier2k6
Copy link
Member

Thank you very much

You're more than welcome, if you notice any other issues with I2P support please feel free to feedback.

@xavier2k6
Copy link
Member

So we will have to conditionally exclude support for I2P in case when qBittorrent is built with libtorrent-1.2.

This needs to be taken care of for next release.

  1. In, the realease, 4.6.0alpha1 (lt12 qt6) I2P does not work at all - neither via I2PD nor via JAVA I2P

#19066

@absolutep absolutep reopened this Jun 5, 2023
@absolutep
Copy link
Author

Currently, this beta release seems to have solved the issue = #19066 (comment)

As shown here = #19066 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants