Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with 4.6 alpha release #19066

Open
absolutep opened this issue Jun 2, 2023 · 17 comments
Open

Issues with 4.6 alpha release #19066

absolutep opened this issue Jun 2, 2023 · 17 comments
Labels

Comments

@absolutep
Copy link

absolutep commented Jun 2, 2023

qBittorrent & operating system versions

3

What is the problem?

Issues with 4.6 alpha realease

  1. In, the realease, 4.6.0alpha1 (lt12 qt6) I2P does not work at all - neither via I2PD nor via JAVA I2P

  2. In, the realease, 4.6.0alpha1 (lt20 qt6) I2P does not show peers - irrespective of what i2p implementation used.

Steps to reproduce

2
1

Additional context

No response

Log(s) & preferences file(s)

No response

@xavier2k6
Copy link
Member

  1. In, the realease, 4.6.0alpha1 (lt12 qt6) I2P does not work at all - neither via I2PD nor via JAVA I2P

Libtorrent 1.2.x doesn't have the I2P changes/requirements as Libtorrent 2.0.x & this was mentioned previously in #18926 (comment)

  1. In, the realease, 4.6.0alpha1 (lt20 qt6) I2P does not show peers - irrespective of what i2p implementation used.

This is because PR#18845 didn't make it in to any official release stable/unstable.

@absolutep
Copy link
Author

when can we expect #18845 to be implemented?

@xavier2k6
Copy link
Member

xavier2k6 commented Jun 2, 2023

when can we expect #18845 to be implemented?

You can use 1 of the CI master builds in the interim (as it is implemented there) or wait for it to be available in the next unstable release, I don't have a timeframe for you on that.

CI master build: qBittorrent-CI_Windows-x64_libtorrent-2.0.9 (with I2P support):
https://github.com/qbittorrent/qBittorrent/suites/13302931935/artifacts/726408261

@Griss168
Copy link

Griss168 commented Jun 4, 2023

I can confirm this (on MacOS x64 + i2pd):

  1. In, the realease, 4.6.0alpha1 (lt12 qt6) I2P does not work at all - neither via I2PD nor via JAVA I2P
  2. In, the realease, 4.6.0alpha1 (lt20 qt6) I2P does not show peers - irrespective of what i2p implementation used.

And also seed over i2p doesnt work. Download work, but seed doesnt.
Tested between qBittorrent 4.6 alpha and BiglyBT 3.4.
Also *.i2p address cant be added manually to peerlist on qbittorrent.

@xavier2k6
Copy link
Member

xavier2k6 commented Jun 8, 2023

Also *.i2p address cant be added manually to peerlist on qbittorrent.

Do you have such a peer to test with?

Any error message displayed?

In any case......

@absolutep Can you test latest master (Libtorrent 2.0.9) build (Windows)?
https://github.com/qbittorrent/qBittorrent/suites/13396505035/artifacts/733555666

@Griss168
Can you test latest master (Libtorrent 2.0.9) build (macOS)?
https://github.com/qbittorrent/qBittorrent/actions/runs/5184996254

@Griss168
Copy link

Griss168 commented Jun 8, 2023

Do you have such a peer to test with?
Any error message displayed?

Sorry, if it was not clear. I mean this options to manually add i2p peer to the peer list:

ht2G

Can you test latest master (Libtorrent 2.0.9) build (macOS)?

Sorry, I cant. This build require MacOS 12.6 or newer, but I am on 10.14.6 and cant update. Also I'm not developer, I'm not able to built it myself. I just try help You with I2P implementation.

@xavier2k6
Copy link
Member

@glassez Ping -> 2wedta7kb7pfav42sw2qe4zuwxo2iywvy2xy6mk3pp475apocsq.b32.i2p seems to be invalid/can't add i2p peer to the peer list. (even with master)

This build require MacOS 12.6 or newer

Where did you see/get this info from?

@Griss168
Copy link

Griss168 commented Jun 8, 2023

I can give you this test torrent: https://www.dropbox.com/s/o481hlx52n6mb0j/2022-07-01-raspios-bullseye-i386.iso.torrent?dl=0
It is just this file: https://downloads.raspberrypi.org/rpd_x86/images/rpd_x86-2022-07-04/2022-07-01-raspios-bullseye-i386.iso
Torrent is downloaded/seeded by BiglyBT from this I2P address: vjr2mwedwkwuthgulqqihxj4vcqou44t4rus4wxbqtbz5eclaacq.b32.i2p
6sxo3lktjqx4bfw6npo7lst2u3m5cto4kjjwvgml4evs7bqmzooq.b32.i2p+

Where did you see/get this info from?

MacOS show me that when I try run it:

ht2N

It say "This version of application qBittorrent.app cant be used with this version of operating system macOS" "You have macOS 10.14.6 and application requires macOS 12.6"

@xavier2k6
Copy link
Member

@glassez @Chocobo1 @thalieht @sledgehammer999

Will I create a "New Issue" for findings below...?

but I am on 10.14.6 and cant update

Catalina was minimum supported since (Thursday March 24th 2022 - qBittorrent v4.4.2) release?

Minimum supported OS version is macOS 10.15 Catalina.


"You have macOS 10.14.6 and application requires macOS 12.6"

This is from Our master CI Builds......

It seems that perhaps "MACOSX_DEPLOYMENT_TARGET" on macOS isn't being fully kept/respected by CMAKE/XCODE?

Two other examples of 4.5.x being run/used under Mojave - 10.14.x:
#18497
#18786

@absolutep
Copy link
Author

@absolutep Can you test latest master (Libtorrent 2.0.9) build (Windows)? https://github.com/qbittorrent/qBittorrent/suites/13396505035/artifacts/733555666

4.6.0beta1 (lt20 qt6) seems to be working properly

1
Untitled

@xavier2k6
Copy link
Member

@absolutep @Vort Can either of you confirm below from latest master?

  1. seed over i2p doesnt work. Download work, but seed doesnt.

  2. *.i2p address cant be added manually to peerlist on qbittorrent.

Reference: #19066 (comment) & #19066 (comment)

@Vort
Copy link
Contributor

Vort commented Jun 9, 2023

@xavier2k6 seeding works, I tested it many times.
Manual adding of I2P addresses do not work.
Also copying of peer address do not work too (looks like command can copy only IP:port, which makes no sense for I2P).

@Vort
Copy link
Contributor

Vort commented Jun 9, 2023

Thanks to torrent link by @Griss168, now I have proof for successfully working upload process:
image

@luzpaz
Copy link
Contributor

luzpaz commented Jun 14, 2023

Can someone summarize/delineate what issues are being reported in this ticket and track their status ?

@xavier2k6
Copy link
Member

Manual adding of I2P addresses do not work.
Also copying of peer address do not work too (looks like command can copy only IP:port, which makes no sense for I2P).

@Vort Thanks, I assume that banning a peer also has issues?! (Haven't tested mysefl)

@Vort
Copy link
Contributor

Vort commented Jun 14, 2023

I assume that banning a peer also has issues?!

It results in crash :(

@xavier2k6
Copy link
Member

Can someone summarize

@luzpaz

  1. See explanation of original/opened ticket in Issues with 4.6 alpha release #19066 (comment)
  2. *.i2p address can't be added manually to peerlist on qbittorrent or copy either it seems, see Issues with 4.6 alpha release #19066 (comment)
  3. Banning an I2P Peer results in a Crash, see Issues with 4.6 alpha release #19066 (comment)
  4. Release Builds/CI have highlighted that our min macOS target support of 10.15 - Catalina isn't being respected/set correctly. (CMake)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants