Remove icons from menu bar and right click menus on OS X

[kristofferR]

Many small details prevent qBittorrent from feeling like a native OS X app, but the icons in the menu bar and right click menus is propably one of the easiest things to fix.

I went through a lot of my other apps on my Mac and icons in contextual menus were almost never used, except in very few logical circumstances. In qBittorrent though icons are used almost everywhere.

The OS X Human Interface Guidelines recommends against displaying an icon for every menu item:

Avoid displaying an icon for every menu item. If you include icons in your menus, include them only for menu items for which they add significant value. A menu that includes too many icons (or poorly designed ones) can appear cluttered and be hard to read.

Personally I think adhering to the OS X Human Interface Guidelines on OS X is pretty much a no-brainer, but I guess adding a non-default preference setting of displaying the options wouldn't be much more work than just removing them outright.

[ngosang]

@Chocobo1 what do you think? If you want to do that keep the icons in Windows and Linux.

[Chocobo1]

I think we should also tag @sledgehammer999 before any further actions.

Also indirectly related, to support having crisp icon on high DPI displays, we need to fetch higher resolution pixmap of the icons. Mybe it's just me but managing so many icon resources is PITA.

[sledgehammer999]

I have no objection in hiding those on OSX. And I think the menubar/menus have a flag for displaying the icons. So we will always assign them, but switch the flag off for OSX.

[Chocobo1]

And I think the menubar/menus have a flag for displaying the icons.

I didn't find it.

Removing the icons from the top menu bar is easy, the code is grouped together so a #if !define(..OSX) will do the trick, see 75a6ce5.
But right-click menus, not quite, the icon path is passed to constructors which means rewriting the code could lower code maintainability...

Another idea, I think instead of removing all of it (and trying to add a icon for every menu item), we should remove non-important action's icon, preserving only the important (most used) ones, so all platforms will behave the same and benefit from this.

[sledgehammer999]

@kristofferR can you check #4757 ?

[sledgehammer999]

Fixed in #6952. Will be available with v3.4.0