This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable UI appearance and corresponding options page #6363
Comments
Copying my #6196 (comment):
Talking from memory here, but I think this also controls the icons for the toolbar and any other icon that follows the icon theme naming spec. |
Confirm. |
What do you mean by this? Complete skinning support? -I think we'll open a can of worms implementing it- |
Torrent state colours may be applied to the whole lines in the transfers list (text and icon), to the icon only or not applied at all, leaving icons monochrome too. |
Yes - I was thinking that as well. We'd need most of the changes from PR #6186 to do this. |
Ok, I understand now. |
To synchronise our thoughts: I'm thinking about a couple of singletons that implement respective interfaces (e.g. @magao, @sledgehammer999: would you agree? |
Sounds reasonable. Think it needs to be done in several steps (PRs):
I'm happy to work on step 1 this weekend. This should be purely a UI task, step 2 could be done in parallel. Do you want to start on step 2 @evsh? |
@magao: yes, this makes sense. Would be happy to implement the second task, but will be busy this weekend and not sure yet about the next one. |
Another little idea: perhaps we should save colour schemes in a separate file. This would allow us to unify default and custom themes (just by distributing a file with the default theme), move colours specification out of the code and allow users to save and exchange the themes. I can think of a few default ones, like Light, Dark, Solarized... |
Step 3 would use bits from my PR #6174. I'd probably change it so the |
Did a quick implementation of step 1 after work - main issue was moving options around the tabs. QtCreator wasn't much help. Use system icon theme is hidden except on non-MacOS UNIX. If the Desktop section is empty then it is hidden (implemented that way so if we add other desktop things here it will show automatically).. All three prefs are migrated to I'm no artist, so I just moved the icon from Behaviour to Appearance, and gave Behaviour the gear. I also changed the WebUI icon to I also want to set up the them change detection and signals before submitting a PR, but does this look like how you want it? |
Let me chime in:
I'd have:
|
IMO, more correct is "Add Torrent from File" (and "Add Torrent from URL"). |
From PR #6186 ...
Thinking about this - maybe the monochrome text theme should be: Actively uploading/downloading - > QPalette::Active I'll prototype it and see how it looks. |
👍 |
@magao Excuse me, but since you do not show any code and the illustration is obvious, what feedback do you expect? |
@ech @sledgehammer999 Sorry - whether the right options had been moved to the Appearance tab, and if the icon selection was reasonable. |
this is discussed in #7360 |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Dear @qbittorrent/qbittorrent-frequent-contributors, @magao, @Zalewa,
and everyone interested, of course.
Let's discuss possible implementations for the appearance settings here. It turns out (#6196) various appearance settings may not only be required to satisfy user taste or preferences, but also be a
requirement for a specific environment. Therefore let's try to summaries requirements and desires for those settings.
I quote @magao comment from PR #6196 here:
I think a user additionally might want to change:
We can provide defaults for colours that depends on an environment (Plasma and Gnome (not really sure) have enough colours in their colour schemes to cover all torrent states).
Referencing related PRs: #3936 #4057 #6156 #6186 #6196
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: