FIX option "Display notifications for added torrents" does not work without "Display notifications"

[allanlaal]

Use case:

Goal:

I want to get an OSD notification for when a new torrent is added when I click magnet links on sites, so I know the link actually got through and is not a spammy ad trick.

Steps:

I open qBittorrent settings -> Advanced:
I see these options are unchecked:

☐ Display notifications
☐ Display notifications for added torrents

I then check "Display notifications for added torrents", since I only want to get notifications for added torrents, not anything else:

☐ Display notifications
☑ Display notifications for added torrents

Since I grew up in the 90s, I hit Apply settings and restart qBittorrent completely for extra settings saving paranoia points

Expected behaviour:

qBittorrent displays OSD notification for every time a magnet link is clicked or torrent added to autoload dir.

Actual behaviour:

qBittorrent does not display any notifications. The torrent is silently added like before

Notes:

the "torrent added" notification is only displayed when both options are checked (somewhat mentioned in #6196 (comment)):

☑ Display notifications
☑ Display notifications for added torrents

versions:

qBittorrent version: 3.3.15
OS: Ubuntu Mate Linux 16.04 LTS
libtorrent: python-libtorrent 1.0.11+git20172007.1c6025e612-1ppa1~xenial1 amd64
Qt: libqtcore4 4:4.8.7+dfsg-5ubuntu2

[thalieht]

I can see the confusion and i think Display notifications works as a control for all notifications. IMO the second option should be disabled/unavailable when the first is unchecked, unless it is changed as you suggest.

[allanlaal]

I think branching Display notifications for added torrents off to work as a separate feature will add value

Logically thinking, users who need an onscreen notification about new torrents means that they add so many torrents, that they don't want to waste the time to check the main qBittorrent window to verify it manually. This also means those users have so many torrents that getting "torrent finished" notifications will be so frequent and distracting that they can't have Display notifications in its current form enabled all the time.
That means Display notifications in its current form and Display notifications for added torrents are mostly mutually exclusive in their use cases.

[thalieht]

I think PR #3810 does it.

[mrandreastoth]

Hard to tell what #3810 is about. Not only that, it's been waiting to be merged for quite some time now. Seems a simpler and more logical solution for now is to simply rename "Display notifications" to "Display notifications for completed torrents" and make "Display notifications for added torrents" ignore the state of that flag. Such a solution would allow more flexibility and choice.

[allanlaal]

PR #3810 did fix this - as of v4.2.0 alpha the issue still persists in the form I originally reported

[sledgehammer999]

This issue has been closed and locked for being too old, and thus either most likely resolved in recent versions or no longer applicable.
If you experience the reported problem or similar in the latest version, please open a new issue report with the requested information in the issue template.

A new issue report with relevant updated data gathered from the latest version is preferable to necroing an old report with a comment like "still happens in version x.y.z", even if you think the bug is the same, or suspect of a regression.
Due to the changes made to the qBittorrent code and its dependencies over time, the exact cause of your problem could be totally different than the original one, despite the visible symptoms of the bug being similar.
Thus, providing relevant updated information is crucial to find and fix the root cause of a recurrent problem or regression.

Thank you for your contributions.