Broken 'Content' tab

[asturel]

Please provide the following information

qBittorrent version and Operating System:

compiled from a2d5d48
Windows 10 Pro x64, libtorrent RC 1.1

libtorrent and Qt version:

qt-everywhere-opensource-src-5.9.0-beta3
libtorrent RC 1.1 (ff63557f582ee5d7f6afbc11e5c80e9d5077d18b)
msvc-15.1

What is the problem:

The content tab is messed, I can't right click or resize the column (if there is column?)

What is the expected behavior:

Steps to reproduce:

Extra info(if any):

Compiled from f3658da and the content tab is ok.
Probably the 92a7479 change broke it? Well something after f3658da

[zeule]

f3658da is broken for me as well.

[thalieht]

No problem for me
current master
qt 5.8.0

[zeule]

I'm also on Qt 5.9.0 beta 3. @asturel, are you sure f3658da is free from the bug on your system?

[zywo]

No problem here.

[zeule]

I had a package built from 94909d9 and it worked fine, now package built from 954f05b shows the bug.

[zeule]

Removing TorrentProperties/qt5/FilesListState config key helps.

[zeule]

So, obviously, when number of columns changes, QHeaderView::restoreState() (at least in Qt 5.9) corrupts header. Could anyone with Qt 5.8, please, do the following experiment:

1. Check out any commit before 5c10a24. For example, f3658da.
2. Compile and run qBt. Exit qBt to save configuration file.
3. Checkout HEAD, compile and run qBt.

Does contents header get corrupted for you?

P.S. As far as I remember, a very similar problem already was solved in the project. Could anyone point out it and the solution?

[thalieht]

@evsh i tested it with f3658da as you said and then back to current master and there is no corruption, no problem for me with qt 5.8.0.

[zeule]

Thanks a lot, @thalieht!

[zeule]

https://bugreports.qt.io/browse/QTBUG-60837

[asturel]

@evsh yeah, currently using f3658da and no problem.

straight upgraded from b5f81a3, but when I went back to f3658da from a2d5d48 I had to restore the previous config which used on b5f81a3 because it kept crashing, may that did the trick?

[zeule]

Crashes? I didn't see any crashes. Could you share a backtrace, please?

[asturel]

Crash occured only when I downgraded from a2d5d48 to f3658da (and keeping my qbittorrent settings), still need it?

[zeule]

Qt sources confirm that this is a Qt bug, introduced after 5.8. Let's hope they fix this before 5.9 release. In the meantime, https://bugreports.qt.io/browse/QTBUG-60837 contains a patch.

[zeule]

Crash occured only when I downgraded from a2d5d48 to f3658da (and keeping my qbittorrent settings), still need it?

So it is not related?

[KingLucius]

This Qt5 bug is fixed now.

[zeule]

Closing then.

[asturel]

sorry, nope.
So http://download.qt.io/official_releases/qt/5.9/5.9.0/single/qt-everywhere-opensource-src-5.9.0.zip.mirrorlist should fix it? Because I recompiled the qt5.9.0 + qbt but the issue isnt fixed :/

[zeule]

If you had the problem, Qt wrote damaged state to the config file. You have no other choice but remove it by hand from the qBt configuration file.

[asturel]

Thanks, works as expected