Qbittorrent 4.0.4 not running external program on torrent completion #8454
Comments
|
Same here... |
|
similar to #8420 I personally upgraded to 4.04 and it works. I'm curious, what type of program runs after downloads complete? I have a .bat/.cmd and it works fine. What's the full command that you're trying to run? |
|
Hmm I tried searching to see if an issue was already up but couldn't find one >.< I myself am running a python script with the command just being |
|
Im running the same command as JourneyOver short of the file location...
Here is a log output from each version on the same file. (they are identical) Edit: Also, I can switch back and forth between versions with reinstalls and the issue follows 4.0.4 |
|
It makes me wonder if 4.0.4 is just not playing nice with python then, as so far that's the only pattern that I am seeing between myself, @cr8tor456 and @marcmv1 |
|
I suspect its related to this change Not sure where to go from here... |
|
@cr8tor456 Delete all files related to qBittorrent, including settings files in %appdata% directory when reinstalling qBittorrent. Then, downgrading to 4.0.3 to fix the issue. |
|
@FranciscoPombal Are you asking me if i did this? I did not. I ran the install for named version and let it uninstall previous version. Works with 4.0.3, not with 4.0.4. I can switch back and forth by reinstalling whichever version (with uninstalling the other version) and the issue follows 4.0.4 |
|
@cr8tor456 I thought you meant that downgrading to 4.0.3 did not fix your issue. The aim of my comment above was to provide a solution for that case. |
|
@FranciscoPombal Understood! My bad if i was confusing with that part previously. :-) To clarify i did not have to delete any files or do anything other than run the 4.0.3 install file and allow it to uninstall "the previous version detected" in order to regain functionality with 4.0.3 |
|
@cr8tor456 Ok, I suggested deleting those files just in case they had been left behind. Anyhow, as my comment above states, this issue should be fixed in the next version (4.0.5) via merging of #8441. Until then, sadly, the only workaround seems to be downgrading to 4.0.3 |
|
@FranciscoPombal Understood, thanks for the info. I can just hold off on 4.0.4 and watch for 4.0.5 then. |
|
Thanks for the info @FranciscoPombal ^^ |
|
Hi, As far as I have seen, external program is executed (in my case, I execute a batch including all the parameters), but parameters are not in order: |
|
Same here, I recently migrated from 2.21 and was hoping the run external program feature would work the same way. Im trying to run a batch script that converts my flacs to apple lossless upon completion. The execution log says the script was launched, but nothing actually happened. (if copy the command from the execution log it runs perfectly) |
|
How can I execute a batch script? The following works neither in 4.0.3, nor in 4.0.4: C:\Windows\System32\cmd.exe /C "pause" |
|
You would need to run c:\dosomething.bat dosomething.bat would contain line/code that you want to execute such as
|
|
I tried that first of course, and it does work. What threw me off was that no window pops up, so I assumed it didn't run. Thanks! |
|
I'm having the same issue. |
|
got the same issue on Ubuntu 16.04 :( |
|
So I tested building the latest master branch since #8441 had been merged into master, and to my disappointment "run external programs on torrent completion" still does not want to work. Running the same command as before |
You should insert |
|
@Chocobo1 Okay so I just tried that method, along with trying pythonw.exe path (which is what my script is supposed to use as it's a python windowless) and then no python.exe path again since I re-input the command (which fixed the backslashes at least), but still it goes and says "running external program" and yet does nothing.
One way I know my script is working is that it's supposed to spit out a .log file from filebot when the command is run, yet running my command on 4.0.4 (and the 4.1.0alpha running on this commit ccc91e2 (which is the latest commit in the master branch) does not produce a log or do anything else on "running" the command) Running 4.0.3 and below it doesn't matter if I insert the python path or not, it works regardless always runs the command/script and always spits out a .log file from filebot. So I know it's not my script that is at fault here. Edit: Must of missed it the first time around but doing the normal
as you can see it's throwing a "not enough values to unpack expected 6 but got 3" error.. I believe the script never threw this error on 4.0.3 and below as I've never seen it before and which is why it worked, but something must of changed in 4.0.4+ that has caused it to do this. |
|
@JourneyOver |
|
@Chocobo1 Looks like that fixes it, but it only works if I enter the path of pythonw.exe or python.exe like so Why was it changed to require that? Not that I fully care, but it seems weird that 4.0.3 and below didn't require that bit. |
Because previously qbt prepended |
|
@Chocobo1 Ah okay gotcha, anyways idk if this is another bug with qbittorrent or what but had a recent download go through but it seems to be making my script fail for some reason but it works on 4.0.3 just fine. Torrent named When I tested the same download on qbittorrent 4.0.3 it passed everything correctly and I didn't have the same problem as above with the whole so far it's been the only one I can reproduce it on 100%, as any others I've downloaded has been passed through just fine on.Sadly I can't see myself sharing the .torrent though for you to test with (at least through here) as it's from a private tracker. |
|
@Chocobo1 I'm calling bug with your pull request of qbittorrent 4.1.0alpha #8669 for the above issue, as I'm getting more .torrents running into the whole qbittorrent appending Qbittorrent logs show but like before upon inspection of my scripts log it shows Again this is only happening on the 4.1.0alpha from your pull request, if I downgrade back to my 4.3.0 release it never does this. |
|
Hmmm, hard to understand why that happens... let's try a simple python script first: import sys
f = open('c:\\windows\\temp\\qbt_exec.txt', 'w')
argc = len(sys.argv)
f.write("number of arguments: " + str(argc) + "\n\n")
for i in range(argc):
f.write(str(i + 1) + ": " + sys.argv[i] + '\n')
f.close()Tell qbt to execute this script (for the specific torrent that exhibits the problem), after execution find the file "c:\windows\temp\qbt_exec.txt" and post it here. |
|
@JourneyOver |
Need to split arguments manually because QProcess::startDetached(QString) will strip off empty parameters. E.g. `python.exe "1" "" "3"` will become `python.exe "1" "3"`. Closes qbittorrent#8454.
|
@Chocobo1 before I update to the next commit here is the qbt_Exec.txt file. qbt_exec.txt That's running now I will go about getting the latest commit built and test it. |
|
@Chocobo1 running latest commit of the PR seems to have fixed the issue possibly (I'm still going to keep an eye on things over the next day or two), it at least passes all the arguments now going by what the qbt_exec.txt says qbt_exec.txt ontop of that I tested using my normal script and it doesn't go and fail either, as it actually passes the directory like so now |
|
I've merged the fix to git master now, closing issue. For others: |
|
Great! so far everything seems to be running just fine on the 4.1.0Alpha. |
|
Workaround here |
|
@blakeusblade this has already been fixed a while back, people just need to wait for the next release or build the latest commits themselves until the next release. |
Solution for MacOS or Linux/Debian users.... I created a wtf.sh script and it is located in my /Users/sean/QBittorent/ directory. Thus I gave the qbittorrent client the following path to execute the my shell script: /Users/sean/QBittorrent/wtf.sh. The wtf.sh script contains only the following (4) lines.
|
Please provide the following information
qBittorrent version and Operating System
qbit version: 4.0.4
OS Version: Windows 10 x64 latest Fall Creator Updates
What is the problem
Upgraded to qbit 4.0.4 and now qbit no longer runs external programs on torrent completion.
What is the expected behavior
for qbit to run external programs on torrent completion.
Steps to reproduce
Extra info(if any)
When I downgraded back to 4.0.3 things work as expected, so this is an issue with something in 4.0.4
The text was updated successfully, but these errors were encountered: