-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qbittorrent-4* does not work without qtsingleapplication #9196
Comments
@zeule |
@zeule @sledgehammer999 would be nice if you guys released 4.1.2 as this bug involves lots of people affected (and cherry picking is not really nice I believe). |
I'll give you the benefit of the doubt and say that this is a typo of the word "guys". |
@sledgehammer999 some misstypes happen :) |
sledgehammer999
pushed a commit
that referenced
this issue
Aug 12, 2018
Look for qtsinglecoreapplication.h when Qt5Widgets module was not found, and qtsingleapplication.h otherwise. Fixes #9196. This also removes Qt4 support from the QtSingleApplication find module.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
qBittorrent version and Operating System
net-p2p/qbittorrent-4.1.1
Gentoo Linux
If on linux, libtorrent and Qt version
---, qt-5.9.6
What is the problem
qbittorrent does not compile without qtsingleapplication.h even if compiling w/o X support
What is the expected behavior
do not require qtsingleapplication.h if compile w/o X (gui) support
Steps to reproduce
1.) compile qtsingleapplication without X support (installs only qtsinglecoreapplication.h)
2.) try to compile qbittorrent without gui support and see
Extra info(if any)
Gentoo bug: https://bugs.gentoo.org/639716
Also #7551 has insufficient fix
The text was updated successfully, but these errors were encountered: