Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1.4 speed estimate is not completely innacurate #9946

Closed
CyrusNajmabadi opened this issue Dec 1, 2018 · 18 comments
Closed

4.1.4 speed estimate is not completely innacurate #9946

CyrusNajmabadi opened this issue Dec 1, 2018 · 18 comments

Comments

@CyrusNajmabadi
Copy link

image

Something in the latest release has changed with speed estimate. It now is often wildly wrong. My home connection is 150mbps. So i'm obviously not downloading at PB/s or EB/s ranges (yes, i've seen the latter). There must be something wrong in the speed estimator where it occasionally divides by an incredibly tiny value, producing some massive value like this. Obviously, this makes the speed chart totally useless. This definitely did not occur in 4.1.3.

@glassez
Copy link
Member

glassez commented Dec 1, 2018

@dzmat?

@Marko-HR
Copy link

Marko-HR commented Dec 1, 2018

If I remember correctly, that was reported before, as well as, different speed in status bar and in the list of torrents.

@dzmat
Copy link
Contributor

dzmat commented Dec 2, 2018

For an unknown reason here slips in a single reading circa 2^63 from underlying code. Divided by 72 (averaging interval for 6 hour graph) it gives spikes of 114 PBytes/s on 6hour graph and 1.3 EBytes/s on 30min graph. But this event happens too rarely and unpredictably to be effectively debugged. Personally I suspect some change in libtorrent, but have no proves here :( .

May be it worth to add some filtering / logging for incoming data?

@CyrusNajmabadi
Copy link
Author

Can you not clamp or filter out clearly excessive values. In general when I've coded up speed estimating software, the greater the deviation from the average, the more samples you need to take to get certainly that things are actually changing. At most you let things grow by 2x per sample. In a bandwidth scenario that means it would take a full 40 samples to truly reach PB/s from MB/s. Since, in reality, people will only go up/down a couple of orders of magnitude, for normal speed changes, you catch up in just a handful of samples. Whereas, if you get utterly crazy values above/below the real value, you aren't really affected unless you keep getting them coming in.

@CyrusNajmabadi
Copy link
Author

Note: it's not just PB or EB range. I also get stuff like this:

image

It seems like there really needs to be something to prevent scaling from going out of control.

@FranciscoPombal
Copy link
Member

@CyrusNajmabadi
Does this happen before/after suspending your system, by any chance? I think I remember seeing this happen once in such circumstances.

@CyrusNajmabadi
Copy link
Author

Nope system never suspends

@CyrusNajmabadi
Copy link
Author

Note that the spikes are completely bizarre:

image

Here we can see a gentle ramp up at a consistent pace. Then, right in the middle, an outlier value that skews the entire result.

@Marko-HR
Copy link

Marko-HR commented Dec 6, 2018

Does anyone know when this problem is going to be fixed? It's happening ever since v4.

screenshot_1

@ltguillaume
Copy link

image

Ooh, I win! Only been seeing this behavior since v4.1.4, too. System wasn't suspended before.

@adem4ik
Copy link
Contributor

adem4ik commented Jun 27, 2019

This issue still reproduceable in v4.1.6 at Win10. I have only 100mbps UP/DL bandwidth.
SQt5_qKAcPU

@Marko-HR
Copy link

This issue still reproduceable in v4.1.6 at Win10. I have only 100mbps UP/DL bandwidth.
SQt5_qKAcPU

Eh, just use v3.3.12. Everything works fine in it. I doubt they'll fix this.

@adem4ik
Copy link
Contributor

adem4ik commented Aug 12, 2019

@MarkoxD it is not that big issue for me and I like overall qB v4.

@bitsadmin
Copy link

Frequently having the same issue. Not horrible, but just a bit annoying. Running v4.2.1 on a 1Gbit Internet connection. Seems to happen more frequently since 2 updates ago or so.
image

@Marko-HR
Copy link

It's so annoying and still isn't fixed. The download/upload speed from torrent list and status bar are still different too.

@CyrusNajmabadi
Copy link
Author

image

Still happening. I don't get why there even is a speed meter in the product if it's going to be so unhelpful...

@Marko-HR
Copy link

image

Still happening. I don't get why there even is a speed meter in the product if it's going to be so unhelpful...

That and increased CPU usage is the only thing keeping me from using the latest version.

@FranciscoPombal
Copy link
Member

Duplicate of #7920

@FranciscoPombal FranciscoPombal marked this as a duplicate of #7920 Mar 11, 2020
@qbittorrent qbittorrent locked and limited conversation to collaborators Mar 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants