Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force recheck multiple torrents one by one. Closes #9120 #10242

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

glassez
Copy link
Member

@glassez glassez commented Feb 1, 2019

No description provided.

@thalieht
Copy link
Contributor

thalieht commented Feb 1, 2019

I re-read the stop_when_ready() docs again and i don't understand if the following means that it could fail and allow the torrent to momentarily start downloading or it's a reassurance that it won't:

// Note that the torrent may transition into a downloading state while
// calling this function, and since the logic is edge triggered you may
// miss the edge. To avoid this race, if the torrent already is in a
// downloading state when this call is made, it will trigger the
// stop-when-ready immediately.

p.s. in PR title and commit i think you meant ...multiple torrents...

@glassez
Copy link
Member Author

glassez commented Feb 1, 2019

i don't understand if the following means that it could fail and allow the torrent to momentarily start downloading

Torrent can start downloading only before stop_when_ready flag is set (e.g. if we call stop_when_ready() while torrent is checking and it is finished checking before the flag is actually set).
But we set this flag before start checking.

@glassez
Copy link
Member Author

glassez commented Feb 1, 2019

p.s. in PR title and commit i think you meant ...multiple torrents...

Of course! 👍

@glassez glassez changed the title Force recheck multiple files one by one. Closes #9120 Force recheck multiple torrents one by one. Closes #9120 Feb 1, 2019
@sledgehammer999
Copy link
Member

@glassez once this is merged, if you aren't bothered, create a PR targeting v4_1_x too.

@glassez glassez merged commit 0413a05 into qbittorrent:master Feb 8, 2019
@glassez
Copy link
Member Author

glassez commented Feb 8, 2019

@glassez once this is merged, if you aren't bothered, create a PR targeting v4_1_x too.

#10266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants