Use IP geolocation database by DB-IP instead of MaxMind

[sledgehammer999]

Closes #11792

[sledgehammer999]

One thing that I forgot to ask about.
Do you have any suggestions about the strings in the about dialog boxes? Translation-wise the way they are broken up may not work with all languages. Some languages may require rearranging the order of the words. I don't know how to achieve that AND maintain the linked URL at the correct word.

[Chocobo1]

I don't know how to achieve that AND maintain the linked URL at the correct word.

You can just place all text in one tr()/QBT_TR() and let translator decide the final outcome, this is better than presenting the broken up sentences.

[sledgehammer999]

You can just place all text in one tr()/QBT_TR() and let translator decide the final outcome, this is better than presenting the broken up sentences.

But in the past we had problems with translators messing up the html tags in their translations.

[glassez]

Then we should use less rich text in qBittorrent UI. Otherwise the reliable solution seems to be impossible.

[sledgehammer999]

Pushed all proposed changes.

[sledgehammer999]

Then we should use less rich text in qBittorrent UI. Otherwise the reliable solution seems to be impossible.

I don't wish to tackle this. If someone has a ready string that I can copy let me know. Otherwise, IMO, lets proceed as-is. There can be another PR by someone else regarding that specific issue.

If there aren't any other issues pending please review-approve.

[glassez]

But in the past we had problems with translators messing up the html tags in their translations.

IMO, it's a shitty idea to try to prevent translators from making mistakes by creating a string that may not be translated correctly into some languages (and at least difficult to translate).

[sledgehammer999]

Ok, I think I resolved the translatable string issue.

[FranciscoPombal]

@sledgehammer999 you probably want to change the two top lines of the .gitingore as well, which currently read:

src/gui/geoip/GeoIP.dat
src/gui/geoip/GeoIP.dat.gz

[sledgehammer999]

you probably want to change the two top lines of the .gitingore as well, which currently read:

Those lines should have been removed a long time ago. In ancient times, qbt windows builds bundled the geoip database too.

[sledgehammer999]

Thanks everyone.