Allow single app instance per configuration

[glassez]

Closes #8653.
Closes #11082.

[thalieht]

Tested.
p.s. Also closes #11082

[FranciscoPombal]

@glassez
Looks good, but isn't this a good time to update the man pages as well? They are missing a ton of options and a description of how to use them and what they do. This new behavior and how to use profileDir and configurationName should also be documented there.

[glassez]

Waiting one more day for @sledgehammer999 review...

[FranciscoPombal]

@glassez So you're not going to address the manpages in this PR (see my previous comment)?

[glassez]

@glassez So you're not going to address the manpages in this PR (see my previous comment)?

Sorry, no.

[FranciscoPombal]

Sorry, no.

Ok.

[arvobowen]

So is this currently a beta release? Also, how do you use this new feature? I'm guessing this allows you to run two different instances of qbittorrent correct?

[glassez]

So is this currently a beta release?

We don't produce betas for minor releases.

I'm guessing this allows you to run two different instances of qbittorrent correct?

Two or more. It produces independent instance for each configuration path/name (you can set it via command line).

[mzso]

So this commit suggests I'm allowed to have one instance only unless I specify another.
This is not what happens.
I created a profile in QB's directory to make it portable and moved my stuff there. However a multiple instance is started whenever I open a torrent file.

[glassez]

So this commit suggests I'm allowed to have one instance only unless I specify another.

It creates (should create) different instances per configuration (i.e. profile path + configuration name).

I created a profile in QB's directory to make it portable and moved my stuff there. However a multiple instance is started whenever I open a torrent file.

Please provide more details.
How do you launch first instance? How do you exactly open torrent file? Do you run qBittorrent binary located within the same path?

[mzso]

So this commit suggests I'm allowed to have one instance only unless I specify another.

It creates (should create) different instances per configuration (i.e. profile path + configuration name).

I created a profile in QB's directory to make it portable and moved my stuff there. However a multiple instance is started whenever I open a torrent file.

Please provide more details.
How do you launch first instance? How do you exactly open torrent file? Do you run qBittorrent binary located within the same path?

Either via a plain icon in the quick launch area, via autorun I have set up.
Opening a torrent is via double click, or enter within Total Commander.

(If I drag and drop a torrent unsurprisingly no new instance is started)

[glassez]

Please provide a log message about used Profile path from both instances.

[mzso]

Seems pretty identical. Apart from the drive letter. (but paths aren't supposed to be case sensitive)

2020.03.27. 10:50 - qBittorrent v4.2.2 elindult
2020.03.27. 10:50 - Futtatás hordozható módban. Automatikusan észlelt profilmappa: D:/Programok/qBittorrent/profile

2020.03.27. 10:51 - qBittorrent v4.2.2 elindult
2020.03.27. 10:51 - Futtatás hordozható módban. Automatikusan észlelt profilmappa: d:/Programok/qBittorrent/profile

[mzso]

@glassez commented on 2020. márc. 26. 20:08 CET:

Please provide a log message about used Profile path from both instances.

The CLI doesn't seem much different either, as per Process Explorer:

"D:\Programok\qBittorrent\qbittorrent.exe"

"d:\Programok\qBittorrent\qbittorrent.exe" "d:\Letöltés\test.torrent"

Not sure why there's a space after the double quote character in the first case.

[glassez]

but paths aren't supposed to be case sensitive

They're case insensitive from the Windows filesystem perspective. But they're still different strings so they produce different instance IDs.
Seems we need to ignore case in profile path on Windows when create instance ID.

[mzso]

An update: It seems like the secondary instance is broken. It doesn't connect to anything. Added torrents never start, the trackers just show "not yet connected" or something in that vein. And the old torrents don't produce any traffic either, not even after hours. (I accidentally closed the first instance one instead of the duplicate)

[glassez]

It seems like the secondary instance is broken. It doesn't connect to anything.

Sure. It uses the same config as the first one so there are conflicts.

[mzso]

Okay. So it seems to work normally now in 4.2.3.

[null-character]

IDK if this is related but in recent versions on qB I get multiple instances unintentionally. Say I have qB open and use the browser to add a few new torrents either via magnet or .torrent.

Sometimes it will open a second instance that never works. So I need to close and re-add it to the correct instance.

Is there a UI way to override this to NEVER allow a second instance?

[glassez]

Can you check what configuration path is printed in Log in both instances (when it happens next time)?

[null-character]

Sure no problem. It happens pretty infrequently though.

[mzso]

Sure no problem. It happens pretty infrequently though.

Last time it was case sensitivity. I guess it will be something similarly trivial...

[null-character]

So it just happened and I checked and they both have the exact same path. Which is 6/5/2020 6:53 PM - Using config directory: C:/Users/autostart/AppData/Roaming/qBittorrent/

The second instance showed a bunch of errors about the port/socket/whatever already being in use.

I closed both instances and re-opened and the file was there and then started to download.

I'm on the latest version of qB and the browser I used to click the link is the new Chromium Edge.

[Zorlin]

Does this apply to -nox? I'm trying to run 10 instances of it and using separate config for each. Cheers~!