Fix outgoing interfaces not getting assigned in case addr is not null.

[rwasef1830]

Fixes #12421

[FranciscoPombal]

Can you confirm you get the expected behavior (i.e. the same as client_test) with this change?

[rwasef1830]

@FranciscoPombal Yes I can confirm that the problem is solved. Now it is making outgoing connections only from the IP I selected in options. It works correctly whether I choose the IP only, or whether I choose both IP and interface.

[rwasef1830]

@Chocobo1 done.

[glassez]

Commit messages should be formatted according to the project Coding Guidelines.

[rwasef1830]

@glassez better ? apologies, I'm new to this repo.

[glassez]

@glassez better ? apologies, I'm new to this repo.

Don't think so... I suppose "in primary branch" refers to implementation details (i.e. to "if-else"). It confuses when reading it itself. But when you read the code it becomes meaningless since code clearly shows it.
Just use your original message but w/o extra detail: "Fix outgoing interface is not getting assigned". You can describe the problem in message body if it is needed.

[rwasef1830]

@glassez ok, is it clearer now ? :-)

[Chocobo1]

@rwasef1830
Thank you!

[Chocobo1]

@rwasef1830
I was testing on qbt master branch with libtorrent RC_1_2 latest and I just found out downloading doesn't work anymore. I can see many peers but they all come and go. I reverted this patch and the problem is gone, care to take a look?
It is important that the issue will only come up when "Any interface" option is selected in advanced settings, specifying an interface such as "eth0" won't see the symptom. And "any addresses" is selected during my testing, not sure if it is related.

[rwasef1830]

I will investigate. Maybe a special case is needed for handling "any interface" + "any address" when handling outgoing connections, it's possible that a blank or empty or invalid address is being set or something. I will investigate.

[rwasef1830]

@Chocobo1 ok the problem is that when selecting "any interface" "any address", outgoing interfaces is set to 0.0.0.0 and :: and that makes all outgoing connections fail (maybe because not valid IP address). Solution is to skip setting outgoing interface when it is equal 0.0.0.0 or [::]. I will make a new pull request.