Use palette colors in pieces bars #13256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
windows ubuntu ubuntu theme |
Chocobo1
reviewed
Aug 16, 2020
jagannatharjun
force-pushed
the
pieces-style
branch
from
8e8c9d9
to
115dc65
Compare
Chocobo1
reviewed
Aug 16, 2020
Chocobo1
previously approved these changes
Aug 16, 2020
jagannatharjun
force-pushed
the
pieces-style
branch
from
115dc65
to
eeb218d
Compare
Chocobo1
previously approved these changes
Aug 16, 2020
glassez
reviewed
Aug 17, 2020
src/gui/properties/piecesbar.cpp
Outdated
| @@ -181,7 +181,7 @@ void PiecesBar::paintEvent(QPaintEvent *) | |||
| QPainter painter(this); | |||
| QRect imageRect(borderWidth, borderWidth, width() - 2 * borderWidth, height() - 2 * borderWidth); | |||
| if (m_image.isNull()) { | |||
| painter.setBrush(Qt::white); | |||
| painter.setBrush(palette().base()); | |||
There was a problem hiding this comment.
Shouldn't you use backgroundColor() here?
| @@ -127,7 +127,7 @@ bool PieceAvailabilityBar::updateImage(QImage &image) | |||
| } | |||
|
|
|||
| if (m_pieces.empty()) { | |||
| image2.fill(Qt::white); | |||
| image2.fill(palette().color(QPalette::Base)); | |||
There was a problem hiding this comment.
Shouldn't you use backgroundColor() here?
| @@ -120,7 +120,7 @@ bool DownloadedPiecesBar::updateImage(QImage &image) | |||
| } | |||
|
|
|||
| if (m_pieces.isEmpty()) { | |||
| image2.fill(Qt::white); | |||
| image2.fill(palette().color(QPalette::Base)); | |||
There was a problem hiding this comment.
Shouldn't you use backgroundColor() here?
| @@ -158,6 +158,10 @@ void PieceAvailabilityBar::clear() | |||
|
|
|||
| QString PieceAvailabilityBar::simpleToolTipText() const | |||
| { | |||
| return tr("White: Unavailable pieces") + '\n' | |||
| + tr("Blue: Available pieces") + '\n'; | |||
| const QString colorBoxBorderColor = palette().color(QPalette::ToolTipText).name(); | |||
There was a problem hiding this comment.
This color is common to all PiecesBar subclasses, isn't it? Then I would make it accessible via its interface like other such colors (e.g. backgroundColor()).
There was a problem hiding this comment.
I think this is not a property of Pieces Bar so I would like to leave it as it is.
There was a problem hiding this comment.
What is the difference with the other colors that are set there?
jagannatharjun
force-pushed
the
pieces-style
branch
2 times, most recently
from
89405d1
to
94e59be
Compare
glassez
reviewed
Aug 21, 2020
jagannatharjun
force-pushed
the
pieces-style
branch
from
94e59be
to
d73757b
Compare
glassez
approved these changes
Aug 22, 2020
Chocobo1
approved these changes
Aug 23, 2020
|
@jagannatharjun |
IceCodeNew
pushed a commit
to IceCodeNew/qBittorrent-Enhanced-Edition
that referenced
this pull request
Aug 28, 2020
Use palette colors in pieces bars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.