Update Changelog

[sledgehammer999]

I did my best to filter out commits that already have went into v4_4_x* or that were internal changes not worthy mentioning to end users.
A review from more and fresh eyes is welcome.
This PR is basically the only blocker for v4.5.0 stable release.

*However, I have included the commits that were backported into v4_4_x after the latest stable release.

[sledgehammer999]

This changelog is missing v4.4.1 and newer before v4.5.0, file should be more in sync with v4.4.x branch?

I intended this PR to be for the 4.5.0 changes.
The changes for the other releases can be backported from v4_4_x branch in another PR.

[thalieht]

6a56001 162273d f673540 are missing.

[glassez]

And maybe this other regression to be looked at before releasing v4.5.0:

• Save correct resume data when added new torrent #18003

There is no such regression in 4.5.x branch.

[sledgehammer999]

I pushed the recommended changes.
Also the news section on the Website is rendered from Markdown. So I converted all quotes to backticks where it made sense. So this:
Add "Export .torrent" action (Chocobo1)

will render as
Add Export .torrent action (Chocobo1)

Of course this will break searching the git log if you copy the string with the backticks.

[sledgehammer999]

@now-im I recall that you made a comment about this. That I should also attribute another person. Was it made in error and you retracted it?

[glassez]

@sledgehammer999
I still believe it would be convenient to add Change log entries in the relevant PRs. Then it wouldn't require so much extra work before the release.

[jagannatharjun]

I've also done substantial work on this. #16587 #16357 #16329 #16298

[glassez]

I've also done substantial work on this. #16587 #16357 #16329 #16298

The startup process has been heavily redesigned since then, so it's unlikely that all of them have a tangible impact on the startup time. #16357 and #16329 apparently still affect. #16587 is unlikely, but it still has an impact when using GUI. As for #16298, there is hardly anything significant left of it in the current code.
So they could be mentioned separately.

[sledgehammer999]

maybe add @jagannatharjun too in the attribution list for this line?

[glassez]

These are all different kind of changes, so I would prefer that they were mentioned separately. I don't want to assign myself all the contribution to improving the startup time, so my contribution can be named differently, e.g. Revamp startup process.

[sledgehammer999]

Revamp startup process or Do RSS serializing on worker thread or Optimize handleFileCompletedAlert or Optimize torrent filters in GUI mean nothing to the end user.
The changelog should reflect what the user will see or experience. Unless I am mistaken your PR and @jagannatharjun 's PRs affect qbittorrent's startup time. That's what the user will experience. He doesn't care how we accomplished it internally. If he cares, the git log is public and shows exactly who did what with greater detail.

That being said, I also intend to mention in the news section that 4.5.0 has a lot of code refactorings by various contributors that result in general program optimization and better code architecture.

[glassez]

The changelog should reflect what the user will see or experience.

👍

your PR and @jagannatharjun 's PRs affect qbittorrent's startup time. That's what the user will experience.

OK, it's up to you. I won't argue.

[glassez]

That being said, I also intend to mention in the news section that 4.5.0 has a lot of code refactorings by various contributors that result in general program optimization and better code architecture.

It would be nice to mention our @qbittorrent/bug-handlers. And a special "thank you" from me to @thalieht - without his expeditious testing of my PRs, my work would be much less productive.
I also want to thank @oorzkws for testing the "improve startup" stuff in circumstances of a really heavy load (about several hundred thousand torrents).

[glassez]

@sledgehammer999
I wonder how we could mention libtorrent changes (and maybe even Qt and other libraries) in qBittorrent release announcements? They also affect our users.

[xavier2k6]

• FEATURE: Introduce a change listen port cmd option (BallsOfSpaghetti)

@Balls0fSteel @OpenSpaghettiSauce Are you ok with the way this is presented?

@sledgehammer999 I have no issue if i'm not given any credit publicly......git history reflects that I co-authored so really that's good enough for me.

@glassez, @Chocobo1 Apologies I haven't been able to help out more with testing & give proper feedback lately.....

[glassez]

@glassez, @Chocobo1 Apologies I haven't been able to help out more with testing & give proper feedback lately.....

Anyone contributes according to their capabilities. That's OK.

[Balls0fSteel]

@xavier2k6 Oh, of course, 100% perfect. Thank you!
(Sorry for swapping back and forth all the time btw! I do it because this user has more "power" and I don't want to mess anything up. So for safety I use the other account for code stuff and this one for Issues, Wiki edit, etc.)

[Mazino-Urek]

@sledgehammer999 I have no issue if i'm not given any credit publicly......git history reflects that I co-authored so really that's good enough for me.

There is no harm in including your name here. It should be included, given your contribution, in my opinion.

[sledgehammer999]

@xavier2k6 I have zero problem mentioning you in the changelog, especially now that others have mentioned you and you're presented as co-author. I missed you in the changelog because I use a script(based on git-log) to pull data from git history as a first step to a changelog. That script queries commit hash, commit title and commit author. Unfortunately git-log doesn't return co-authors.

To all: The release is scheduled for this weekend.

[xavier2k6]

@sledgehammer999 No problem, If you intend to release a build on Qt 6.4 series - I'd stick to Qt 6.4.0 as Qt 6.4.1 has been released but text size being displayed in certain areas like transfer list, menu's etc. seems to have been increased......unsure if it's a regression on Qt's part or if they've changed default font sizes etc. (need to look in to it more)

EDIT:
@sledgehammer999 Seems to be a Qt regression -> QTBUG-108593, reference also: QTBUG-108481

[sledgehammer999]

@xavier2k6 thanks for the heads up.