Destroy desktop integration at correct place #18108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glassez
added
GUI
thalieht
approved these changes
Nov 30, 2022
This was referenced Nov 30, 2022
sledgehammer999
approved these changes
Nov 30, 2022
Great deduction of the possible problem. There is one user who tested it and confirmed that it works. I also asked in the other 2 bug reports for someone to test. |
shanechko
reviewed
Nov 30, 2022
shanechko
approved these changes
Nov 30, 2022
glassez
added a commit
to glassez/qBittorrent
that referenced
this pull request
Nov 30, 2022
Otherwise it is destructed in QObject destructor, i.e. after GUI application is already destructed. This can be related to some problems with system tray icon. PR qbittorrent#18108. Closes qbittorrent#18093.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it is destructed in QObject destructor, i.e. after GUI application is already destructed.
This can be related to some problems with system tray icon.
Closes #18093.