Allow to hide individual Status filter items #18273
Conversation
Closes qbittorrent#18082 Qwidget-> UpdateGeometry does not work on hidden widgets, so sizeHint method of QWidget is overrided in StatusFilterWidget. In sizeHint method, constant 20 is used because QWidgetListItem->sizeHint().height returns -1.
|
@thalieht I just added qt6 support, but could not understand this error. I cant fathom it. Could you explain or guide? I also have a question, it fails in 11, but in annotations I can only see 4 of them? For ex this one is not being showed? 4 out of 11
|
|
I don't think you should be looking at the Mac CI now, it's broken in other PR's too. I'm sorry i'm not a programmer so i have no idea what's happening in application.cpp. |
- Added qt6 support - Removed unnecessary trailing whitespaces
|
@lapaz17 I just tried the windows CI build (Qt 6) & Appveyor build (Qt5) - there's no selectable filters in the context menu... I'm not seeing anything like the screenshot from #18082 (comment) - just resume torrents/pause torrents/remove torrents.
|
You have to right click on the "STATUS" label itself. |
Thank you!
|
glassez
changed the title
|
I haven't come across any issues.......awaiting others opinions/review. |
|
I start my review from a user perspective. First of all I believe that All is a pseudo state and it should be always visible. |
I was thinking the same thing as per #18082 (comment)
Do you think it would behave any different to how we hide the |
I just want to say that it should switch to |
|
This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity. |
|
@lapaz17, at what stage is this PR, will you continue to do it? |
Im sorry, no.. |
I totally agree but that doesn't happen even before this PR with What I mean is, If you create a
Agree, again. |
|
For this PR or another iteration of it to be approved, these 2 conditions need to be met.
|
|
@lapaz17, maybe you can still finalize it? |
For me hide then show Status filter restore previously selected item (at least without restart the app in between).
This is strictly required by me. |
Unfortunatley I destroyed my dev setup. |
|
Can someone please review and fix this? This is the #1 feature I'm waiting for and lapaz did a great job getting it 99% of the way there... qbittorrent sucks so much without this. |
|
That doesn't seems to be mkv, but if it's the same as #18082 (comment) then I'd like to object. No other header on the left sidebar (CATEGORIES, TAGS, TRACKERS) have their own context menus. So the STATUS must have no context menu as well. I think approach suggested in #18082 (comment) is better (that is to add new submenu under View menu similar to View/Log). I, myself, am annoyed by number of statuses we have there. Ideally, I'd like to have something similar to uTorrent 2.x where we have 4 main statuses + optional error status if some torrents have errors. I understand that statuses are added because someone wants them, but I'm happy to find out I'm not the only one who does not :) If everyone agrees with such solution I might try to implement it but it's unlikely to be ready for 4.6 release in this case. |
|
This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity. |
|
This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity. |
|
I'm bumping since this says its inactive Looks like it needs a review. |
It has conflicting files that need to be resolved & @lapaz17 can't work on this any further it seems -> #18273 (comment) |
|
This PR is stale because it has been 60 days with no activity. This PR will be automatically closed within 7 days if there is no further activity. |
|
Bump for activity as this will not be archived until solved. Major issue. |
|
It doesn't make any sense, the author refused to complete the work. |
|
@aboose-aboose-aboose This PR has been abandoned, There was a new PR created that can auto-hide zero status filters which has been included in 4.6.x |
but it's not the same thing!!i may want to see some 0 status like "active torrents" even when there is no active torrent and hide those who are almost the same like "completed" and "seed" (since i never stop torrents after competion. and this was never working for me, even in 4.5 can you tell me how i do it?. i'm right clicking on Status and nothing appears (4.5.5) |
Closes #18082
Qwidget-> UpdateGeometry does not work on hidden widgets, so sizeHint method of QWidget is overrided in StatusFilterWidget. In sizeHint method, constant 20 is used because QWidgetListItem->sizeHint().height returns -1.
Screnshot