New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose 'DHT bootstrap nodes' setting #19594
Conversation
This setting requires a way to reset it to default IMO. If it's accidentally deleted, users would have to go search in the source code (unlikely) or come ask about it here. |
What about users clicking on the ps. after all, it is advanced settings, we can't help if users messes with it and shoot their feet... |
Empty string could load default nodes. |
I think it's not worth neglecting some friendliness after all, if it's as trivial as what I suggested above. |
How about I change the setting semantics to: if the lineedit widget is empty use the default nodes, otherwise use the user provided value? However, the default node URLs will not be visible to users... |
That's what I was suggested. |
The default nodes are too long to be shown entirely when using placeholder text. And I consider it important to show the full list to the user. |
This allows user to select DHT bootstrap nodes. Or even use their own bootstrap nodes.
This allows user to select DHT bootstrap nodes. Or even use their own bootstrap nodes.