Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't forget to resume "missing files" torrent when rechecking #20747

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

glassez
Copy link
Member

@glassez glassez commented Apr 22, 2024

Related issue description: #17962 (comment)

@glassez glassez added the Core label Apr 22, 2024
@glassez glassez added this to the 4.6.5 milestone Apr 22, 2024
@glassez glassez requested review from thalieht and a team and removed request for thalieht April 22, 2024 12:06
@glassez glassez mentioned this pull request Apr 22, 2024
@thalieht
Copy link
Contributor

If I just hit Force Re-Check on a Missing Files state, then it hangs at Checking 0.0

Should be fixed by #20747.

Can't reproduce the problem in master.

@glassez
Copy link
Member Author

glassez commented Apr 22, 2024

If I just hit Force Re-Check on a Missing Files state, then it hangs at Checking 0.0

Should be fixed by #20747.

Can't reproduce the problem in master.

I can.
Note, that it should be non-stopped torrent.

@thalieht
Copy link
Contributor

Note, that it should be non-stopped torrent.

(Force) resumed-missing files becomes (force) resumed after recheck
stopped-missing files becomes stopped after recheck.
No problems.

@glassez
Copy link
Member Author

glassez commented Apr 22, 2024

(Force) resumed-missing files becomes (force) resumed after recheck

In master (and v4.6.x) it goes in checking state but doesn't do anything actually.

@thalieht
Copy link
Contributor

Ok i reproduced the problem.

@glassez glassez merged commit ca71c18 into qbittorrent:master Apr 24, 2024
10 of 14 checks passed
@glassez glassez deleted the recheck-missing-files branch April 24, 2024 06:15
glassez added a commit to glassez/qBittorrent that referenced this pull request May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants