Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebUI: Use enabled search plugins by default #20969

Merged
merged 1 commit into from
Jun 24, 2024
Merged

WebUI: Use enabled search plugins by default #20969

merged 1 commit into from
Jun 24, 2024

Conversation

Piccirello
Copy link
Member

This switches the WebUI's default search plugin from "All plugins" to "Only enabled". "All plugins" is a nonsensical default since it completely ignores whether plugins are enabled. This now matches the behavior of the GUI.

Closes #20558

@Piccirello Piccirello added WebUI WebUI-related issues/changes Search engine Issues related to the search engine/search plugins functionality labels Jun 17, 2024
@Piccirello Piccirello requested a review from a team June 17, 2024 20:34
@Piccirello Piccirello mentioned this pull request Jun 17, 2024
Closed
@glassez
Copy link
Member

glassez commented Jun 19, 2024

"All plugins" is a nonsensical default since it completely ignores whether plugins are enabled.

"All plugins" is a nonsensical option basically, since it makes disabling plugins meaningless.
I would either

  1. remove "All plugins" option altogether so that disabled plugins are actually disabled and can't be used, or...
  2. remove the option of disabling plugins, and instead allow you to mark some Favorites. Then it would make sense to choose between "All plugins" and "Only favorites".

@glassez glassez requested a review from a team June 19, 2024 12:08
@glassez glassez changed the title Use enabled search plugins by default in WebUI WebUI: Use enabled search plugins by default Jun 20, 2024
@glassez glassez added this to the 5.0 milestone Jun 22, 2024
@Piccirello
Copy link
Member Author

  1. remove "All plugins" option altogether so that disabled plugins are actually disabled and can't be used, or...

I'm going to hold off on implementing this right now, but this seems like a reasonable option.

@glassez
Copy link
Member

glassez commented Jun 24, 2024

I'm going to hold off on implementing this right now

I don't expect this from this PR, especially since it has a very limited scope. This was a general remark.

@glassez glassez merged commit 9d87a81 into qbittorrent:master Jun 24, 2024
14 checks passed
@Piccirello Piccirello deleted the webui-default-search-plugin branch June 24, 2024 19:28
sledgehammer999 pushed a commit to sledgehammer999/qBittorrent that referenced this pull request Jun 25, 2024
@Piccirello @sledgehammer999
Use enabled search plugins by default in WebUI
210650a 
PR qbittorrent#20969.
Closes qbittorrent#20558.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glassez glassez glassez approved these changes

@Chocobo1 Chocobo1 Chocobo1 approved these changes

Assignees
No one assigned
Labels
Search engine Issues related to the search engine/search plugins functionality WebUI WebUI-related issues/changes
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

WebUI displays Jackett error even when its search plugin is disabled
3 participants
@Piccirello @glassez @Chocobo1