Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support wildcards for filtering torrent list and torrent content #4170

Merged
merged 1 commit into from
Nov 30, 2015
Merged

Support wildcards for filtering torrent list and torrent content #4170

merged 1 commit into from
Nov 30, 2015

Conversation

vlakoff
Copy link
Contributor

@vlakoff vlakoff commented Nov 25, 2015

Supersedes #4164.

Uses the WildcardUnix mode.

@sledgehammer999
Copy link
Member

Fix this error:

gui/torrentcontentfiltermodel.cpp:41:41: error: ‘setPatternSyntax’ was not declared in this scope

(and similar ones on the other variables)

@vlakoff
Copy link
Contributor Author

vlakoff commented Nov 26, 2015

@sledgehammer999 It should be fixed now. (some confusion between QRegExp and QSortFilterProxyModel, I apologize)

However, I had to change to Wildcard mode. If you would prefer WildcardUnix mode, I have another branch ready as well.

@sledgehammer999
Copy link
Member

IMO, WildcardUnix is a better mode. So rename you other branch to this one, and then force push onto this one. This PR will autoupdate.

@vlakoff
Copy link
Contributor Author

vlakoff commented Nov 26, 2015

I prefer WildcardUnix too. This branch has been updated and should be ready to go.

@vlakoff
Copy link
Contributor Author

vlakoff commented Nov 26, 2015

Just to point out there shouldn't be a loss in performances, as the FixedString mode also works using a regex that is escaped. So the only added calculations are the QRegExp instanciations instead of reusing instance.

@sledgehammer999
Copy link
Member

Thanks.

sledgehammer999 added a commit that referenced this pull request Nov 30, 2015
Support wildcards for filtering torrent list and torrent content
@sledgehammer999 sledgehammer999 merged commit f4ef063 into qbittorrent:master Nov 30, 2015
@vlakoff
Copy link
Contributor Author

vlakoff commented Aug 24, 2016

Just referencing issue #4065 which this PR solved.

@vlakoff
Copy link
Contributor Author

vlakoff commented May 18, 2021

I added a comment on a related PR, about updating this code to QRegularExpression: #9255 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants