Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic fixes for WebUI upload and download windows #6818

Merged
merged 1 commit into from
May 22, 2017

Conversation

naikel
Copy link
Contributor

@naikel naikel commented May 20, 2017

These are cosmetic fixes for the pull request #6475 that was merged like 3 months ago but I think it doesn't look good.

Here's how it looks right now:

upload

Here's what I'm proposing:

upload

No unnecessary scrollbar and no centering of the checkmark, it's so far way is hard to see what it is for.

Same for download, here's how it looks right now:

download

And here's what I'm proposing:

download

Copy link
Contributor

@zeule zeule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeule zeule added the WebUI WebUI-related issues/changes label May 20, 2017
@zeule zeule requested a review from glassez May 21, 2017 22:33
Copy link
Member

@glassez glassez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested, but screenshots LGTM.

@zeule zeule merged commit 47960b2 into qbittorrent:master May 22, 2017
@zeule
Copy link
Contributor

zeule commented May 22, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants