Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI displays Jackett error even when its search plugin is disabled #20558

Closed
drws opened this issue Mar 16, 2024 · 4 comments · Fixed by #20969
Closed

WebUI displays Jackett error even when its search plugin is disabled #20558

drws opened this issue Mar 16, 2024 · 4 comments · Fixed by #20969
Labels
Search engine Issues related to the search engine/search plugins functionality WebUI WebUI-related issues/changes

Comments

@drws
Copy link

drws commented Mar 16, 2024

qBittorrent & operating system versions

qBittorrent: 4.6.3 x64
Operating system: Arch Linux x64
Qt: 5.15.12
libtorrent-rasterbar: 1:2.0.9

What is the problem?

Jacket search plugin's error Jackett: api key error! is displayed in search results (only in WebUI) even when the Jacket search plugin is disabled. Also tried to reload the WebUI with Ctrl+F5 to no avail, the error is still displayed as a last search result.

Steps to reproduce

  1. Search in WebUI with Jackett not being avaliable and its search plugin being disabled.
  2. (In some cases?) a Jackett plugin's error is displayed alongside search results.

Additional context

No response

Log(s) & preferences file(s)

No response

@thalieht thalieht added WebUI WebUI-related issues/changes Search engine Issues related to the search engine/search plugins functionality labels Mar 16, 2024
@luzpaz
Copy link
Contributor

luzpaz commented Mar 22, 2024

Can someone locate the code for this ? What's the fix ?

@luzpaz luzpaz added the Confirmed bug An issue confirmed by project team to be considered as a bug label Mar 25, 2024
@Piccirello
Copy link
Member

What search plugins are selected when performing the search? I suspect "All plugins" is selected, rather than "Only enabled".

@drws
Copy link
Author

drws commented May 2, 2024

You're right, thank you. Why is that the default? Available, even?

And what purpose does disabling a plugin even has when that's the default?

@Piccirello
Copy link
Member

Why is that the default? Available, even?

Good question. I don't remember the original thought process behind this decision, but I've put up #20969 to address it.

@Piccirello Piccirello removed the Confirmed bug An issue confirmed by project team to be considered as a bug label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Search engine Issues related to the search engine/search plugins functionality WebUI WebUI-related issues/changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants