Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit and selectable #44

Closed
wants to merge 27 commits into from
Closed

Conversation

NielsTalens
Copy link
Contributor

Hi guys,

I found that it works better for me when I can select the lists and cards items instead of copying the id. Also I really missed an Edit function so I can undo the many typo's I make.

I ended up:

  • making every function for cards and list selectable (except archive all) ,
  • adding a Edit command.

Regards,
Niels

NielsTalens and others added 27 commits December 6, 2019 15:09
- Both the card show as the card edit now start with
a selection of the possible list within a board and the a select based
on the cards in this list (like board select).

- I shortened the commands to the first letter of each command word (b s
    = board select) for the items I changed.
- Moving cards can now also be done by selecting the original list, the card a the
desired list.
- It is possible to also use only the first letters of most commands and
subcommands. They are listed in the help file.
… they can also

be used by the list commands.
to the list>cards. Committing sometimes helps.
abbreviations in board and list tests.
@qcam
Copy link
Owner

qcam commented Jan 2, 2020

Hi, thank you so much for working on the PR. I'd be gladly taking the edit command patch. Regarding making every list selectable, I think I'd prefer this #15 more. Given someone might have many cards in the board, this might not be the best solution IMO. WDYT? Also, could you please remove the unrelated style changes?

Thank you. 💙

@qcam
Copy link
Owner

qcam commented Jan 9, 2020

Thanks for working on the PR again. #46 has been merged which I believe would solve the problem proposed by this PR.

@qcam qcam closed this Jan 9, 2020
@NielsTalens
Copy link
Contributor Author

@qcam I am sure #46 solves the problem quite well. Would you still want to merge the edit patch once I find time put in a seperate branch?

@qcam
Copy link
Owner

qcam commented Jan 9, 2020

That will be very appreciated! Thank you 🙏! Do you want me to reopen this PR or would you like opening a new one?

@NielsTalens
Copy link
Contributor Author

No need to reopen. I created a new pull request for it: #48 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants