Edit cards #48
Closed
Edit cards #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Edit to lib/3llo/api/card.rb, - Added both the card Edit command as the presentation, - Added card command tests in: spec/3llo/card_command_factory_spec.rb.
Closed
|
@NielsTalens thanks for extracting the PR. I think it looks great functionality wise. However, something has been changed recently on the master branch. Could you please rebase and resolve the conflicts? After that I think it's perfect to merge. |
|
Gentle ping! Would you mind if I resolve the conflicts in the PR? |
|
I am so sorry man! I had started with it but then I got cought up in something else. |
|
No worries at all. Sorry for making so much changes during the past few days. |
|
Closing in favor of #55 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here are the changes that only include the Edit Card functionality and additional tests for the Card commands. Hopefully they are ok. Otherwise I love to hear from you.
Regards,
Niels