Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column properties not updated immediately after Guess Column Properties #263

Closed
Stephen-Gates opened this issue Nov 28, 2017 · 2 comments
Closed
Labels
env:MacOS This issue is related to running Data Curator on macOS env:Windows This issue is related to running Data Curator on Windows est:Moderate Moderate effort to implement fn:Set-Properties priority:High problem:Bug A bug
Milestone

Comments

@Stephen-Gates
Copy link
Contributor

Current Behaviour (for problems)

With the Column Properties panel showing, after Guess Column Properties the Column properties are not updated for the column displayed.

If you move to another column and then return to the original column, the values are updated

Expected Behaviour

Column properties are updated immediately after being changed

Your Environment

  • Data Curator version: 0.5.2
  • Operating System and version: Windows 7
@Stephen-Gates Stephen-Gates added env:Windows This issue is related to running Data Curator on Windows fn:Set-Properties problem:Bug A bug labels Nov 28, 2017
@Stephen-Gates Stephen-Gates modified the milestones: Backlog, v1.x.x Dec 1, 2017
@Stephen-Gates Stephen-Gates added the env:MacOS This issue is related to running Data Curator on macOS label Dec 2, 2017
@Stephen-Gates
Copy link
Contributor Author

Related to #134

  • if column properties panel is open, update values immediately
  • if column properties panel is closed, open the panel

@Stephen-Gates Stephen-Gates modified the milestones: v1.x.x, 0.9.0 Jan 10, 2018
@ghost ghost added the est:Moderate Moderate effort to implement label Jan 10, 2018
@ghost
Copy link

ghost commented Jan 10, 2018

Have observable that we use for keeping column names up-to-date. Need to add/enhance observable to grab all column properties (not just names), while keeping column name observer in place for foreign keys/primary keys.

@Stephen-Gates Stephen-Gates added status:In-progress We're working on this right now status:Ready 👋 This pull request is ready for review and removed status:In-progress We're working on this right now labels Jan 16, 2018
@ghost ghost closed this as completed in bde3e0d Jan 18, 2018
@Stephen-Gates Stephen-Gates removed the status:Ready 👋 This pull request is ready for review label Jan 18, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
env:MacOS This issue is related to running Data Curator on macOS env:Windows This issue is related to running Data Curator on Windows est:Moderate Moderate effort to implement fn:Set-Properties priority:High problem:Bug A bug
Projects
None yet
Development

No branches or pull requests

1 participant