Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foreign key relationship is not validated #302

Closed
Stephen-Gates opened this issue Dec 7, 2017 · 3 comments
Closed

Foreign key relationship is not validated #302

Stephen-Gates opened this issue Dec 7, 2017 · 3 comments
Labels
env:Windows This issue is related to running Data Curator on Windows est:Moderate Moderate effort to implement fn:Validation priority:High problem:Bug A bug status:Blocked 😢 We can't progress this until something else happens
Milestone

Comments

@Stephen-Gates
Copy link
Contributor

Related to #300 ?

Current Behaviour (for problems)

I create a foreign key relationship. Validate. No errors reported, however data contains errors

Expected Behaviour

Validation reports FK errors

Your Environment

  • Data Curator version: 0.7.0
  • Operating System and version: e.g. Windows 7
@Stephen-Gates Stephen-Gates added env:Windows This issue is related to running Data Curator on Windows fn:Validation problem:Bug A bug labels Dec 7, 2017
@Stephen-Gates Stephen-Gates added this to the v0.8.0 milestone Dec 7, 2017
@ghost
Copy link

ghost commented Dec 7, 2017

Hi @Stephen-Gates
Wasn't able to include feature for validation yet - (I removed it from release notes).
I already use the frictionless naming underneath so once I send the property through shouldn't take much to get going.

@Stephen-Gates Stephen-Gates added the status:In-progress We're working on this right now label Dec 13, 2017
@ghost
Copy link

ghost commented Dec 13, 2017

Little bit more involved as frictionless libraries requires adding relations in map format before validation (cannot just add foreign keys to descriptor alone). Won't make it to release 0.80.

@Stephen-Gates Stephen-Gates removed the status:In-progress We're working on this right now label Dec 13, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v0.8.0, v1.x.x Dec 13, 2017
@Stephen-Gates Stephen-Gates changed the title Foreign key relationship not validated Foreign key relationship is not validated Dec 31, 2017
@Stephen-Gates Stephen-Gates modified the milestones: v1.x.x, 0.9.0 Jan 10, 2018
@ghost ghost added the est:Moderate Moderate effort to implement label Jan 10, 2018
@Stephen-Gates Stephen-Gates modified the milestones: v0.9.0, v0.10.0 Feb 1, 2018
@ghost
Copy link

ghost commented Feb 11, 2018

Work completed.
But also dependent on frictionlessdata/tableschema-js#124

@ghost ghost added the status:Blocked 😢 We can't progress this until something else happens label Feb 12, 2018
@ghost ghost closed this as completed in b186220 Feb 14, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
env:Windows This issue is related to running Data Curator on Windows est:Moderate Moderate effort to implement fn:Validation priority:High problem:Bug A bug status:Blocked 😢 We can't progress this until something else happens
Projects
None yet
Development

No branches or pull requests

1 participant