-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public IP package to work over HTTPs and DNS #158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c31e6d3
to
7218554
Compare
44c5231
to
d0513a6
Compare
1ac3e2e
to
1ac7e50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.sum
which you can ignore since I added themiekg/dns
package, required to resolve Chaos records for CloudflareHow to mock resolver???or just trust in the integration testAssign each IP method to the right IP version for http to avoid breaking changes and add comment to remove on next major version bump. Add an exported method to do so in the publicip/http package which returns what ipversions the provider supportsNo need, there are already separatedIP_METHOD
environment variables for each IP versionDocument cycling for HTTP fetcher is sequential and not random selectionNo one caresNext PR
PUBLICIP_METHOD
to selecthttp
,dns
or both (indicate it will cycle between each at random uniformly distributed)IP_METHOD
->PUBLICIP_HTTP_IP_PROVIDER
while keeping retrocompatibilityPUBLICIP_DNS_IP_PROVIDER
(valid for ip4or6, ip4 and ip6)And in another PR