-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Category filtering for NordVPN #1806
Conversation
@qdm12 Can I get your review on this please? Also I saw you were concerned about the potential file size increase for servers.json, it's rather minimal at .9MB increase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍 💯
I left a few comments, the most important one being:
If the group can only be
legacy_standard
orlegacy_p2p
, would it be reasonable instead to just set thePortForward
server model boolean to true when encounteringlegacy_p2p
and not have categories at all?
That of course removes a lot of the fun in this PR, but it does make sense so far to me; even if there are other categories, I'm not certain there would be a usage to filter by category except for p2p? 🤔
7793495
to
a194906
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay re-reviewing, here are some answers on previous conversations! 👍
57a0645
to
059b128
Compare
9ac2d82
to
2543aa5
Compare
I've rebased and reworked your PR, just big congrats on the code, it's quite good 💯 !
|
2543aa5
to
96b6a45
Compare
Actually never mind, checking more the response from https://api.nordvpn.com/v2/servers?limit=10 it shows |
96b6a45
to
f41e9d9
Compare
- update NordVPN servers data built-in
f41e9d9
to
65bc059
Compare
Aims to fix #1643
I am not a GO developer, please read this code carefully!
After talking to NordVPN support, as long as a server supports P2P, a P2P connection will be established once it's determined there is a need for it (IE seeing P2P traffic). There's no way of knowing if it has connected to the P2P server other than contacting support with the IP address or results from
curl https://ipleak.net/json/
. I did ask if there was a way of starting the connection and specifying P2P from the get-go to avoid any switching but they said there was no documentation on this.I've also seen online that this switch from standard to P2P can result in you being reconnected to a "better" server, but this could also introduce latency.
TL;DR Nord claims it "just works"
Also unsure on testing? I've added a single test case for the categories - please let me know if there's anything more I can do here.