Report update error, if update was not applied to at least one active replica (#2976) #3013
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's currently a slight consistency "gap" in how we handle updates:
Partial
nodes have to be able to accept and apply update requests (from the user and other nodes)Partial
state, and the lastActive
replica is practically deadPartial
node, and the onlyActive
node is deadPartial
node that will accept and apply the updateActive
replicas, thePartial
node won't be able to propagate this update to itActive
replica is back online, it will initiate shard transfers toPartial
nodesPartial
nodes, whileActive
node was offlineThis PR checks that update was successfully applied to at least one
Active
node and report an error to the user if not.Resolves #2976. Currently based on #3012, will be rebased on
dev
once it's merged.All Submissions:
dev
branch. Did you create your branch fromdev
?New Feature Submissions:
cargo +nightly fmt --all
command prior to submission?cargo clippy --all --all-features
command?Changes to Core Features: