Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When reading points, go over non-appendable segments first #3995

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

timvisee
Copy link
Member

@timvisee timvisee commented Apr 9, 2024

When reading points from segments, always read from non-appendable segments first.

Points may be moved from non-appendable to appendable, because we don't lock all segments together read ordering is very important here.

All Submissions:

  • Contributions should target the dev branch. Did you create your branch from dev?
  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests?
  2. Have you formatted your code locally using cargo +nightly fmt --all command prior to submission?
  3. Have you checked your code using cargo clippy --all --all-features command?

Copy link
Contributor

@ffuugoo ffuugoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎👍

@timvisee timvisee requested a review from generall April 9, 2024 12:51
@timvisee timvisee merged commit 64c0543 into dev Apr 9, 2024
18 checks passed
@timvisee timvisee deleted the fix-missing-points-chaos-testing branch April 9, 2024 13:29
timvisee added a commit that referenced this pull request Apr 22, 2024
* When reading points, go over non-appendable segments first

* Improve getting non-appendable then appendable segments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants