On read operations, go over non-appendable segments first #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffuugoo
approved these changes
Apr 9, 2024
timvisee
commented
Apr 9, 2024
… during read operations
timvisee
force-pushed
the
read-non-appendable-first
branch
from
83cf1e8
to
c835024
Compare
ffuugoo
approved these changes
Apr 10, 2024
| self.segments | ||
| .values() | ||
| .cloned() | ||
| .partition(|segment| !segment.get().read().is_appendable()) |
generall
approved these changes
Apr 10, 2024
timvisee
added a commit
that referenced
this pull request
Apr 22, 2024
* On read operations, go over non-appendable segments first * Read segments in two "phases" (first non-appendable, then appendable) during read operations * Resolve clippy warnings * Collect non-appendable and appendable segments in single pass * Minor cleanup --------- Co-authored-by: Roman Titov <ffuugoo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends #3995
All segment reading operations must read over non-appendable segments first.
Points may be moved from non-appendable to appendable, because we don't lock all segments together read ordering is very important here.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?