Add resharding status to API #4319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JojiiOfficial
force-pushed
the
resharding_status_in_api
branch
from
08eeedd
to
0c6d184
Compare
timvisee
reviewed
May 24, 2024
|
@JojiiOfficial instead of merging dev into here, could you please rebase the relevant commit onto the latest dev instead? The merges add about 20 unrelated commits onto this branch. |
JojiiOfficial
force-pushed
the
resharding_status_in_api
branch
from
baab53b
to
38f0f87
Compare
timvisee
approved these changes
May 29, 2024
timvisee
force-pushed
the
resharding_status_in_api
branch
from
38f0f87
to
126c665
Compare
timvisee
force-pushed
the
resharding_status_in_api
branch
2 times, most recently
from
31c77ac
to
c00c2c1
Compare
|
I've extended this to render a comment on the current resharding status. It is now also adapted to all the changes we've made recently. Here's a short demo: Screencast.from.2024-06-20.11-35-25.mp4 |
timvisee
force-pushed
the
resharding_status_in_api
branch
from
e965dc8
to
d8202ca
Compare
timvisee
force-pushed
the
resharding_status_in_api
branch
from
d8202ca
to
39eaaf7
Compare
timvisee
force-pushed
the
resharding_status_in_api
branch
from
39eaaf7
to
0e473c9
Compare
We'll enable it again to always be included when releasing resharding
9 tasks
timvisee
added a commit
that referenced
this pull request
Jul 10, 2024
* Add resharding status to API * Report human readable resharding status in cluster info * Fix delete stage not showing shard IDs * Update OpenAPI spec * Temporarily hide resharding operations in cluster info if empty We'll enable it again to always be included when releasing resharding * Remove resharding details from cluster info in gRPC until release --------- Co-authored-by: timvisee <tim@visee.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked in: #4213
Depends on: #4509
Adds resharding status information to the gRPC API and REST API
Tasks
dev