Simplify resharding stages, add method to describe current stage for humans #4509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvisee
force-pushed
the
resharding-describe-stage
branch
from
7263d95
to
84e7a55
Compare
ffuugoo
approved these changes
Jun 20, 2024
generall
pushed a commit
that referenced
this pull request
Jun 21, 2024
…humans (#4509) * Simplify possible stages and stage handling * Add method to describe current resharding stage in human readable format * Drop in-memory driver state before removing its file * Reformat * Delete state through SaveOnDisk wrapper * Store resharding progress description in resharding progress tracker * Periodically update driver state: progress and list of peers * Mark hidden operations to be exposed for resharding release * Fix clippy warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked in: #4213
This simplifies the resharding stages we have. We now don't have start/end variants anymore, but a single variant for each stage.
It also adds a method to describe the current stage in human readable format. This will be connected to the cluster info later to show the current progress to users.
All Submissions:
devbranch. Did you create your branch fromdev?New Feature Submissions:
cargo +nightly fmt --allcommand prior to submission?cargo clippy --all --all-featurescommand?