Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example in README not compiling #22

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Fix example in README not compiling #22

merged 1 commit into from
Mar 15, 2023

Conversation

timvisee
Copy link
Member

@timvisee timvisee commented Mar 6, 2023

Fixes #21

This makes the example in the README up-to-date with the latest qdrant-client and tokio versions.

This was referenced Mar 6, 2023
Merged
Closed
@azayarni azayarni requested a review from generall March 13, 2023 15:56
agourlay
agourlay approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@agourlay agourlay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for taking the time to fix this example.

I think it would make sense to move this code into a root level examples crate to make sure it stays in sync.

Feel free to tackle it otherwise I will take care of it.

@agourlay agourlay merged commit 9f63cd7 into qdrant:master Mar 15, 2023
@timvisee
Copy link
Member Author

timvisee commented Mar 15, 2023 •
edited

I think it would make sense to move this code into a root level examples crate to make sure it stays in sync.

I've extracted it to examples/ in #23, what do you think?

You can run it with cargo run --example search.

@agourlay
Copy link
Member

agourlay commented Mar 15, 2023 •
edited

@timvisee Fantastic, I should have checked all the PRs before hand 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agourlay agourlay agourlay approved these changes

@generall generall Awaiting requested review from generall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Provided sample code does not work, outdated?
2 participants
@timvisee @agourlay