Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/202008 folder rename #82

Merged
merged 10 commits into from
Jul 31, 2020
Merged

Feature/202008 folder rename #82

merged 10 commits into from
Jul 31, 2020

Conversation

qdraw
Copy link
Owner

@qdraw qdraw commented Jul 31, 2020

PR Details

Add option to rename the current folder

Description / Motivation and Context

To do a resync after renaming folders to provide a UI

Related Issue

no issue

How Has This Been Tested

  • C# Unit tests
  • Typescript Unit tests
  • Other Unit tests
  • Manual tests
  • Automatic End2end tests (framework not included)

Types of changes

  • Added for new features
  • Breaking change fix or feature that would cause existing functionality to change
  • Changed for non-breaking changes in existing functionality for example docs change / refactoring / dependency upgrades
  • Deprecated for soon-to-be removed features
  • Removed for now removed features
  • Fixed for any bug fixes
  • Security in case of vulnerabilities

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (update when needed)
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the ./history.md document

@codecov
Copy link

codecov bot commented Jul 31, 2020

Codecov Report

Merging #82 into master will increase coverage by 3.49%.
The diff coverage is 98.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   85.22%   88.72%   +3.49%     
==========================================
  Files         300      108     -192     
  Lines       10815     3290    -7525     
  Branches     2252      899    -1353     
==========================================
- Hits         9217     2919    -6298     
+ Misses       1300      371     -929     
+ Partials      298        0     -298     
Flag Coverage Δ
#clientapp 88.72% <98.11%> (+0.14%) ⬆️
#netcore ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...anisms/modal-archive-mkdir/modal-archive-mkdir.tsx 91.83% <ø> (ø)
...isms/modal-archive-rename/modal-archive-rename.tsx 97.67% <97.67%> (ø)
...components/organisms/menu-archive/menu-archive.tsx 88.46% <100.00%> (+0.83%) ⬆️
...lview-rename-file/modal-detailview-rename-file.tsx 83.82% <100.00%> (ø)
starsky/starsky/Controllers/HealthController.cs
starsky/starsky/Controllers/ImportController.cs
starsky/starsky/Controllers/ApiController.cs
starsky/starskycore/Services/SyncService.cs
starsky/starsky/Startup.cs
.../starsky.foundation.platform/Helpers/EnumHelper.cs
... and 188 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3518327...2e1a81b. Read the comment docs.

@qdraw qdraw merged commit 2f90fa1 into master Jul 31, 2020
@qdraw qdraw deleted the feature/202008_folder_rename branch July 31, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant